Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dramatiq integration from @jacobsvante #3397

Merged
merged 22 commits into from
Aug 8, 2024
Merged

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Aug 5, 2024

This is the code of sentry-dramatiq.

As described in this GitHub issue (#3387) @jacobsvante, the original maintainer of this integations, is not doing any Python anymore and wants to donate his integration to Sentry so we can take care of it.

This PR adds the current version of the DramatiqIntegration to our repo.

Fixes #3387

Documentation PR: getsentry/sentry-docs#11015

@antonpirker antonpirker added the New Integration Integrating with a new framework or library label Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 81.17647% with 16 lines in your changes missing coverage. Please review.

Project coverage is 79.79%. Comparing base (5529c70) to head (05000db).

✅ All tests successful. No failed tests found.

Files Patch % Lines
sentry_sdk/integrations/dramatiq.py 81.17% 8 Missing and 8 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3397   +/-   ##
=======================================
  Coverage   79.78%   79.79%           
=======================================
  Files         133      134    +1     
  Lines       14418    14503   +85     
  Branches     3036     3052   +16     
=======================================
+ Hits        11504    11573   +69     
- Misses       2083     2091    +8     
- Partials      831      839    +8     
Files Coverage Δ
sentry_sdk/integrations/dramatiq.py 81.17% <81.17%> (ø)

... and 2 files with indirect coverage changes

@antonpirker antonpirker marked this pull request as ready for review August 7, 2024 10:36
@antonpirker
Copy link
Member Author

Tested with this example project:
https://github.com/antonpirker/testing-sentry/tree/main/test-dramatiq

@antonpirker
Copy link
Member Author

Errors with stack traces and local vars are there:
Screenshot 2024-08-07 at 12 56 54

@antonpirker
Copy link
Member Author

Additional dramatiq information is in the contexts and an extra:
Screenshot 2024-08-07 at 12 56 36

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See some small comments. Overall LGTM. Thanks for porting <3

sentry_sdk/integrations/dramatiq.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/dramatiq.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/dramatiq.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/dramatiq.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/dramatiq.py Outdated Show resolved Hide resolved
@antonpirker antonpirker merged commit da0392f into master Aug 8, 2024
124 checks passed
@antonpirker antonpirker deleted the antonpirker/dramatiq branch August 8, 2024 13:07
@jacobsvante
Copy link
Contributor

Thank you so much for integrating it ❤️

sentrivana added a commit that referenced this pull request Aug 12, 2024
This is the code from [sentry-dramatiq](https://github.com/jacobsvante/sentry-dramatiq). 

As described in this GitHub issue (#3387) @jacobsvante,  the original maintainer of this integration, is not doing any Python anymore and wants to donate his integration to Sentry so we can take care of it. 

This PR adds the current version of the `DramatiqIntegration` to our repo. (The original integrations has been ported to the new SDK 2.x API)

Fixes #3387
---------

Co-authored-by: Ivana Kellyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Integration Integrating with a new framework or library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: sentry-dramatiq integration
3 participants