Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(django): Don't let RawPostDataException bubble up #3553

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Sep 20, 2024

Django might raise a RawPostDataException when we attempt to read the body to include it in the event. We don't know what triggers this (something something DRF probably), but whatever the reason is, we shouldn't error out.

Fixes #3045
Fixes #3539

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.54%. Comparing base (ed614c0) to head (1c1a4b0).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3553      +/-   ##
==========================================
+ Coverage   84.49%   84.54%   +0.05%     
==========================================
  Files         133      133              
  Lines       13837    13840       +3     
  Branches     2927     2927              
==========================================
+ Hits        11691    11701      +10     
+ Misses       1420     1415       -5     
+ Partials      726      724       -2     
Files with missing lines Coverage Δ
sentry_sdk/integrations/_wsgi_common.py 85.58% <100.00%> (+1.32%) ⬆️

... and 4 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review September 20, 2024 15:36
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@sentrivana sentrivana merged commit 0ee7c50 into master Sep 23, 2024
125 checks passed
@sentrivana sentrivana deleted the ivana/django-rawpostdataexception branch September 23, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants