Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the Native Bridges #1874

Closed
philipphofmann opened this issue Nov 5, 2021 · 6 comments
Closed

Add tests for the Native Bridges #1874

philipphofmann opened this issue Nov 5, 2021 · 6 comments

Comments

@philipphofmann
Copy link
Member

RNSentry.m has no tests. We could add a layer of abstraction, unit tests in Swift and run them in CI to validate its functionality.

@marandaneto
Copy link
Contributor

also for Android, so I made it more generic, thanks.

@philipphofmann
Copy link
Member Author

I wouldn't mind having two issues and / or two PRs so they get merged faster.

@bruno-garcia
Copy link
Member

I don't disagree with the issue but worth mentioning that unit testing this has limited value as compared to an integration test. That's because this type is called by React Native (RCT_EXPORT_METHOD) and the type marshaling plays a role here too. Additionally, there's very little logic.

@philipphofmann philipphofmann changed the title Add unit tests for the Native Bridges Add tests for the Native Bridges Nov 5, 2021
@marandaneto
Copy link
Contributor

I believe some pieces could be unit tested but indeed, integration/e2e would play a bigger role.

@philipphofmann
Copy link
Member Author

Integration tests make more sense because even if the unit tests are green the functionality could be broken because the underlying functionality changed.

@krystofwoldrich
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

6 participants