-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for the Native Bridges #1874
Comments
also for Android, so I made it more generic, thanks. |
I wouldn't mind having two issues and / or two PRs so they get merged faster. |
I don't disagree with the issue but worth mentioning that unit testing this has limited value as compared to an integration test. That's because this type is called by React Native ( |
I believe some pieces could be unit tested but indeed, integration/e2e would play a bigger role. |
Integration tests make more sense because even if the unit tests are green the functionality could be broken because the underlying functionality changed. |
|
RNSentry.m has no tests. We could add a layer of abstraction, unit tests in Swift and run them in CI to validate its functionality.
The text was updated successfully, but these errors were encountered: