Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): tracesSampler becomes NSNull in iOS and the app cannot be started #1872

Merged
merged 4 commits into from
Nov 5, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 5, 2021

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

Closes #1864

💚 How did you test it?

running with sampler

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the title changelog fix(ios): tracesSampler becomes NSNull in iOS and the app cannot be started Nov 5, 2021
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we could add a layer of abstraction to add tests in Swift for the whole bridge. I can help you with that. Of course not in this PR. What do you think?

Comment on lines +65 to +66
NSMutableDictionary * mutableOptions =[options mutableCopy];
[mutableOptions setValue:beforeSend forKey:@"beforeSend"];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l:

Suggested change
NSMutableDictionary * mutableOptions =[options mutableCopy];
[mutableOptions setValue:beforeSend forKey:@"beforeSend"];
NSMutableDictionary * mutableOptions = [options mutableCopy];
mutableOptions[@"beforeSend"] = beforeSend;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep as it is and change in another PR, there are more places in this class doing the same way

ios/RNSentry.m Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor Author

LGTM. I think we could add a layer of abstraction to add tests in Swift for the whole bridge. I can help you with that. Of course not in this PR. What do you think?

yep, I intend to do that after cleaning up all the JS issues first, also for Android, will hook you up when we are there, thanks.

@marandaneto marandaneto merged commit dd19927 into master Nov 5, 2021
@marandaneto marandaneto deleted the fix/perf-conf-sync branch November 5, 2021 10:08
@philipphofmann
Copy link
Member

philipphofmann commented Nov 5, 2021

LGTM. I think we could add a layer of abstraction to add tests in Swift for the whole bridge. I can help you with that. Of course not in this PR. What do you think?

yep, I intend to do that after cleaning up all the JS issues first, also for Android, will hook you up when we are there, thanks.

Agree, I created an issue so we don't forget about it #1874.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracesSampler becomes NSNull in iOS and the app cannot be started
2 participants