Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Add Attachments #2463

Merged
merged 23 commits into from
Sep 15, 2022
Merged

(feat) Add Attachments #2463

merged 23 commits into from
Sep 15, 2022

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Sep 8, 2022 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Add attachments support for RN. Supported attachments are string (will be send as is) and Uint8Array. File paths are not supported as RN doesn't have build-in FS. Support for certain libs used in RN can be added later if necessary.

💡 Motivation and Context

💚 How did you test it?

Using sample app and unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@krystofwoldrich krystofwoldrich marked this pull request as draft September 9, 2022 11:29
marandaneto
marandaneto reviewed Sep 12, 2022
View reviewed changes
ios/RNSentry.m Outdated Show resolved Hide resolved
marandaneto
marandaneto reviewed Sep 12, 2022
View reviewed changes
src/js/wrapper.ts Outdated Show resolved Hide resolved
@krystofwoldrich krystofwoldrich marked this pull request as ready for review September 14, 2022 10:11
marandaneto
marandaneto reviewed Sep 14, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
marandaneto
marandaneto reviewed Sep 14, 2022
View reviewed changes
test/wrapper.test.ts Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor

@krystofwoldrich left a few comments, just a few things to address and ready to go, thanks for doing this.

marandaneto
marandaneto approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @krystofwoldrich

@krystofwoldrich krystofwoldrich merged commit 396f4f7 into main Sep 15, 2022
@krystofwoldrich krystofwoldrich deleted the krystofwoldrich/attachments branch September 15, 2022 09:15
@krystofwoldrich krystofwoldrich mentioned this pull request Sep 15, 2022
Merged
@marandaneto marandaneto mentioned this pull request Sep 15, 2022
Closed
@krystofwoldrich krystofwoldrich mentioned this pull request Sep 16, 2022
Merged
@krystofwoldrich krystofwoldrich mentioned this pull request Sep 29, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krystofwoldrich @marandaneto @bruno-garcia