Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new react native tracing options based on JS sdk #2481

Merged

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

Fix: #2471

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@krystofwoldrich krystofwoldrich changed the base branch from main to 5.0.0 September 16, 2022 13:40
@krystofwoldrich krystofwoldrich force-pushed the krystofwoldrich/reactNativeTracingOptionsTimeRefactor branch from c929d12 to 168e10f Compare September 16, 2022 13:45
@krystofwoldrich
Copy link
Member Author

Sorry for the force push, but I started this on the main branch and I didn't want to introduce other changes in 5 besides the options change.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2022

Android Performance metrics 🚀

Plain With Sentry Diff
Startup time (ms) 326.19 338.72 12.53
Size (bytes) 27072261 29211304 2139043

@krystofwoldrich krystofwoldrich marked this pull request as ready for review September 16, 2022 14:08
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2022

iOS Performance metrics 🚀

Plain With Sentry Diff
Startup time (ms) 1243.39 1276.67 33.28
Size (bytes) 1133621 1504736 371115

@krystofwoldrich krystofwoldrich added this to the 5.0.0 milestone Sep 16, 2022
@marandaneto marandaneto merged commit e3a10bb into 5.0.0 Sep 22, 2022
@marandaneto marandaneto deleted the krystofwoldrich/reactNativeTracingOptionsTimeRefactor branch September 22, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single time unit and postfix for ReactNativeTracingOptions
2 participants