-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(callback): Callback given to Sentry are execute safely #2502
Conversation
Co-authored-by: Manoel Aranda Neto <[email protected]>
So the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @krystofwoldrich
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Callback given to Sentry are execute safely ([#2502](https://github.com/getsentry/sentry-react-native/pull/2502)) If none of the above apply, you can opt out of this check by adding |
📢 Type of change
📜 Description
These callback would crash the whole app if error is not caught.
I've thought about creating one safe() method that could wrap any callback, but for different callback the behaviour changes. Sometimes it makes sense to return undefined, sometimes defaults...
💡 Motivation and Context
Closes: #2499
💚 How did you test it?
Sample app.
📝 Checklist
🔮 Next steps