Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN 0.65.0 as a new min for SDK v5 #2687

Merged
merged 6 commits into from
Jan 10, 2023
Merged

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Dec 9, 2022

The same cahnges just to test CI on v5

#skip-changelog

0.65.0 is the first version that supports iOS 11 and higher like our iOS SDK.
RN 0.64.0 supports iOS 10 and higher.

That's why I think we should support 0.65.0 and higher, as there should be no issue with the native deps.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 380.82 ms 390.78 ms 9.96 ms
Size 17.73 MiB 20.08 MiB 2.35 MiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 339.52 ms 369.84 ms 30.32 ms
d091239+dirty 425.61 ms 447.11 ms 21.50 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 17.73 MiB 19.95 MiB 2.22 MiB
d091239+dirty 17.73 MiB 19.95 MiB 2.22 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1298.45 ms 1325.74 ms 27.29 ms
Size 2.36 MiB 2.74 MiB 384.17 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 337.18 ms 351.74 ms 14.56 ms
Size 7.15 MiB 8.13 MiB 1003.83 KiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 321.42 ms 342.74 ms 21.32 ms
d091239+dirty 340.16 ms 366.42 ms 26.26 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 7.15 MiB 8.00 MiB 874.27 KiB
d091239+dirty 7.15 MiB 8.00 MiB 874.38 KiB

@github-actions
Copy link
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

sentry-cocoa v7 and v8 has min ios version 11 and rn 0.65 is the oldest version supporting ios 11
rn 0.64 supports ios 10
@krystofwoldrich krystofwoldrich changed the title V5 - React Native Version Matrix CI RN 0.65.0 as a new min for SDK v5 Jan 9, 2023
@krystofwoldrich krystofwoldrich marked this pull request as ready for review January 9, 2023 09:56
@krystofwoldrich
Copy link
Member Author

@marandaneto Metrics are flaky. Otherwise, this is ready.

@krystofwoldrich krystofwoldrich merged commit 5bb8026 into 5.0.0 Jan 10, 2023
@krystofwoldrich krystofwoldrich deleted the rn-matrix-e2e-tests-v5 branch January 10, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants