Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update Cocoa SDK to v8.3.3 #2925

Merged
merged 1 commit into from
Mar 29, 2023
Merged

chore(deps): update Cocoa SDK to v8.3.3 #2925

merged 1 commit into from
Mar 29, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Bumps scripts/update-cocoa.sh from 8.3.2 to 8.3.3.

Auto-generated by a dependency updater.

Changelog

8.3.3

Fixes

  • View hierarchy not sent for crashes (#2781)
  • Crash in Tracer for idle timeout (#2834)

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Mar 25, 2023
@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 25, 2023 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 320.78 ms 339.96 ms 19.18 ms
Size 17.73 MiB 19.75 MiB 2.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms

App size

Revision Plain With Sentry Diff
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 385.21 ms 422.36 ms 37.15 ms
94f9b87+dirty 319.37 ms 330.10 ms 10.73 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 17.73 MiB 20.04 MiB 2.31 MiB
94f9b87+dirty 17.73 MiB 19.75 MiB 2.01 MiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 25, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 282.57 ms 336.17 ms 53.60 ms
Size 7.15 MiB 8.03 MiB 903.20 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms

App size

Revision Plain With Sentry Diff
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 269.29 ms 290.76 ms 21.47 ms
94f9b87+dirty 300.47 ms 353.74 ms 53.27 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 7.15 MiB 8.09 MiB 962.83 KiB
94f9b87+dirty 7.15 MiB 8.03 MiB 901.79 KiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 25, 2023 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1239.71 ms 1250.94 ms 11.23 ms
Size 2.92 MiB 3.39 MiB 487.33 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e73f4ed+dirty 1282.90 ms 1309.30 ms 26.40 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
9a3ca65+dirty 1276.40 ms 1279.14 ms 2.74 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
15c80ab+dirty 1248.41 ms 1251.24 ms 2.83 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms

App size

Revision Plain With Sentry Diff
e73f4ed+dirty 2.92 MiB 3.38 MiB 475.71 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
9a3ca65+dirty 2.92 MiB 3.37 MiB 464.32 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
15c80ab+dirty 2.92 MiB 3.39 MiB 481.56 KiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 1263.68 ms 1273.90 ms 10.22 ms
94f9b87+dirty 1269.94 ms 1273.11 ms 3.17 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 2.92 MiB 3.38 MiB 474.71 KiB
94f9b87+dirty 2.92 MiB 3.39 MiB 485.98 KiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 3 times, most recently from d716a03 to 319bc5c Compare March 29, 2023 09:48
@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 29, 2023 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1249.68 ms 1258.18 ms 8.50 ms
Size 2.36 MiB 2.83 MiB 480.34 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms

App size

Revision Plain With Sentry Diff
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 1214.59 ms 1224.90 ms 10.31 ms
94f9b87+dirty 1260.32 ms 1283.72 ms 23.40 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 2.36 MiB 2.82 MiB 468.48 KiB
94f9b87+dirty 2.36 MiB 2.83 MiB 479.26 KiB

krystofwoldrich
krystofwoldrich approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) March 29, 2023 12:13
@krystofwoldrich krystofwoldrich merged commit a115c54 into main Mar 29, 2023
@krystofwoldrich krystofwoldrich deleted the deps/scripts/update-cocoa.sh branch March 29, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@marandaneto marandaneto Awaiting requested review from marandaneto

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @web-flow