fix(ios): Disable HTTP Client Errors on all platforms by default #2931

krystofwoldrich · 2023-03-27T11:14:35Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

In JS this feature is enabled by integration, the presence of the integration is transformed to a bool flag for the ios SDK.

💡 Motivation and Context

closes: Unify HTTP Client Errors behaviour across RN platforms #2882

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

CHANGELOG.md

github-actions · 2023-03-27T11:40:44Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	279.84 ms	283.34 ms	3.50 ms
Size	17.73 MiB	19.74 MiB	2.01 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`8900e1a`+dirty	430.68 ms	456.13 ms	25.44 ms
`86d6d2c`+dirty	332.90 ms	352.45 ms	19.55 ms
`76d1baf`+dirty	335.72 ms	355.52 ms	19.80 ms
`9a3ca65`+dirty	326.93 ms	330.14 ms	3.21 ms
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`d197b5c`+dirty	338.94 ms	354.87 ms	15.93 ms

App size

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`8900e1a`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`86d6d2c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`76d1baf`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`9a3ca65`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`d197b5c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB

github-actions · 2023-03-27T11:51:01Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1219.29 ms	1242.28 ms	22.99 ms
Size	2.36 MiB	2.83 MiB	479.29 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms
`86d6d2c`+dirty	1267.55 ms	1286.21 ms	18.66 ms
`76d1baf`+dirty	1244.10 ms	1268.52 ms	24.42 ms
`9a3ca65`+dirty	1247.06 ms	1274.58 ms	27.52 ms
`52a8031`+dirty	1280.88 ms	1289.78 ms	8.90 ms
`70caa60`+dirty	1218.27 ms	1230.30 ms	12.03 ms
`15c80ab`+dirty	1223.74 ms	1228.96 ms	5.22 ms
`d197b5c`+dirty	1217.61 ms	1242.66 ms	25.05 ms

App size

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB
`86d6d2c`+dirty	2.36 MiB	2.82 MiB	462.82 KiB
`76d1baf`+dirty	2.36 MiB	2.82 MiB	469.45 KiB
`9a3ca65`+dirty	2.36 MiB	2.82 MiB	462.89 KiB
`52a8031`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`70caa60`+dirty	2.36 MiB	2.83 MiB	479.27 KiB
`15c80ab`+dirty	2.36 MiB	2.83 MiB	474.49 KiB
`d197b5c`+dirty	2.36 MiB	2.82 MiB	462.86 KiB

github-actions · 2023-03-27T11:59:28Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1278.76 ms	1301.96 ms	23.20 ms
Size	2.92 MiB	3.39 MiB	486.03 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms
`76d1baf`+dirty	1245.00 ms	1257.76 ms	12.76 ms
`9a3ca65`+dirty	1276.40 ms	1279.14 ms	2.74 ms
`52a8031`+dirty	1255.96 ms	1273.00 ms	17.04 ms
`70caa60`+dirty	1279.08 ms	1281.54 ms	2.46 ms
`15c80ab`+dirty	1248.41 ms	1251.24 ms	2.83 ms
`d197b5c`+dirty	1234.80 ms	1249.20 ms	14.40 ms

App size

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB
`76d1baf`+dirty	2.92 MiB	3.38 MiB	475.74 KiB
`9a3ca65`+dirty	2.92 MiB	3.37 MiB	464.32 KiB
`52a8031`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`70caa60`+dirty	2.92 MiB	3.39 MiB	486.04 KiB
`15c80ab`+dirty	2.92 MiB	3.39 MiB	481.56 KiB
`d197b5c`+dirty	2.92 MiB	3.37 MiB	464.41 KiB

github-actions · 2023-03-27T12:10:48Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	257.44 ms	302.57 ms	45.13 ms
Size	7.15 MiB	8.03 MiB	901.71 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	262.98 ms	311.02 ms	48.04 ms
`8900e1a`+dirty	371.40 ms	377.70 ms	6.31 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms
`76d1baf`+dirty	339.02 ms	408.65 ms	69.63 ms
`9a3ca65`+dirty	344.96 ms	358.92 ms	13.96 ms
`52a8031`+dirty	330.72 ms	358.76 ms	28.03 ms
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms
`15c80ab`+dirty	276.38 ms	327.54 ms	51.17 ms
`d197b5c`+dirty	258.75 ms	313.61 ms	54.86 ms

App size

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	7.15 MiB	8.09 MiB	965.94 KiB
`8900e1a`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB
`76d1baf`+dirty	7.15 MiB	8.09 MiB	964.41 KiB
`9a3ca65`+dirty	7.15 MiB	8.09 MiB	962.83 KiB
`52a8031`+dirty	7.15 MiB	8.09 MiB	965.95 KiB
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`15c80ab`+dirty	7.15 MiB	8.09 MiB	966.13 KiB
`d197b5c`+dirty	7.15 MiB	8.09 MiB	962.72 KiB

src/js/wrapper.ts

src/js/sdk.tsx

marandaneto

Left a comment otherwise LGTM

numandev1 · 2023-03-29T09:06:33Z

@krystofwoldrich when it will release?

numandev1 · 2023-03-29T11:09:40Z

@krystofwoldrich can you release an alpha or beta version for it?

krystofwoldrich added 2 commits March 27, 2023 13:03

fix(ios): Disable HTTP Client Errors on all platforms by default

3b73084

Update changelog

ff368af

krystofwoldrich requested a review from marandaneto as a code owner March 27, 2023 11:14

krystofwoldrich commented Mar 27, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

aa821d7

marandaneto reviewed Mar 27, 2023

View reviewed changes

src/js/wrapper.ts Outdated Show resolved Hide resolved

Use bool option to switch http errors

8c5bacf

krystofwoldrich requested a review from marandaneto March 27, 2023 17:06

marandaneto reviewed Mar 28, 2023

View reviewed changes

src/js/sdk.tsx Show resolved Hide resolved

marandaneto approved these changes Mar 28, 2023

View reviewed changes

Add test of user overwrite of HttpClient integration

e798a45

krystofwoldrich merged commit 8abb290 into main Mar 29, 2023

krystofwoldrich deleted the kw-http-client-errors-platform-settings branch March 29, 2023 08:51

krystofwoldrich mentioned this pull request Mar 30, 2023

fix(changelog): Correct HTTP Client Errors entry and add an example #2942

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ios): Disable HTTP Client Errors on all platforms by default #2931

fix(ios): Disable HTTP Client Errors on all platforms by default #2931

krystofwoldrich commented Mar 27, 2023

github-actions bot commented Mar 27, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Mar 27, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Mar 27, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Mar 27, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

marandaneto left a comment

numandev1 commented Mar 29, 2023

numandev1 commented Mar 29, 2023

fix(ios): Disable HTTP Client Errors on all platforms by default #2931

fix(ios): Disable HTTP Client Errors on all platforms by default #2931

Conversation

krystofwoldrich commented Mar 27, 2023

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Mar 27, 2023 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Mar 27, 2023 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Mar 27, 2023 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Mar 27, 2023 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

marandaneto left a comment

Choose a reason for hiding this comment

numandev1 commented Mar 29, 2023

numandev1 commented Mar 29, 2023

github-actions bot commented Mar 27, 2023 •

edited

Loading

github-actions bot commented Mar 27, 2023 •

edited

Loading

github-actions bot commented Mar 27, 2023 •

edited

Loading

github-actions bot commented Mar 27, 2023 •

edited

Loading