feat(tracing): Add `enableTracing` option #2933

krystofwoldrich · 2023-03-27T17:44:58Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Add enableTracing option

💡 Motivation and Context

closes: Add enableTracing option to SDK #2923

💚 How did you test it?

sample app

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2023-03-27T17:46:16Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 3084d1c

github-actions · 2023-03-27T18:09:06Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	411.98 ms	430.53 ms	18.55 ms
Size	17.73 MiB	19.74 MiB	2.01 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`8900e1a`+dirty	430.68 ms	456.13 ms	25.44 ms
`86d6d2c`+dirty	332.90 ms	352.45 ms	19.55 ms
`76d1baf`+dirty	335.72 ms	355.52 ms	19.80 ms
`9a3ca65`+dirty	326.93 ms	330.14 ms	3.21 ms
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`d197b5c`+dirty	338.94 ms	354.87 ms	15.93 ms

App size

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`8900e1a`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`86d6d2c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`76d1baf`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`9a3ca65`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`d197b5c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB

Previous results on branch: kw-enable-tracing-option

Startup times

Revision	Plain	With Sentry	Diff
`df67025`+dirty	381.72 ms	395.57 ms	13.85 ms

App size

Revision	Plain	With Sentry	Diff
`df67025`+dirty	17.73 MiB	19.74 MiB	2.01 MiB

github-actions · 2023-03-27T18:20:22Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1264.14 ms	1280.82 ms	16.68 ms
Size	2.36 MiB	2.83 MiB	479.29 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms
`86d6d2c`+dirty	1267.55 ms	1286.21 ms	18.66 ms
`76d1baf`+dirty	1244.10 ms	1268.52 ms	24.42 ms
`9a3ca65`+dirty	1247.06 ms	1274.58 ms	27.52 ms
`52a8031`+dirty	1280.88 ms	1289.78 ms	8.90 ms
`70caa60`+dirty	1218.27 ms	1230.30 ms	12.03 ms
`15c80ab`+dirty	1223.74 ms	1228.96 ms	5.22 ms
`d197b5c`+dirty	1217.61 ms	1242.66 ms	25.05 ms

App size

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB
`86d6d2c`+dirty	2.36 MiB	2.82 MiB	462.82 KiB
`76d1baf`+dirty	2.36 MiB	2.82 MiB	469.45 KiB
`9a3ca65`+dirty	2.36 MiB	2.82 MiB	462.89 KiB
`52a8031`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`70caa60`+dirty	2.36 MiB	2.83 MiB	479.27 KiB
`15c80ab`+dirty	2.36 MiB	2.83 MiB	474.49 KiB
`d197b5c`+dirty	2.36 MiB	2.82 MiB	462.86 KiB

Previous results on branch: kw-enable-tracing-option

Startup times

Revision	Plain	With Sentry	Diff
`df67025`+dirty	1258.90 ms	1278.89 ms	20.00 ms

App size

Revision	Plain	With Sentry	Diff
`df67025`+dirty	2.36 MiB	2.83 MiB	479.26 KiB

github-actions · 2023-03-27T18:34:32Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1256.44 ms	1285.57 ms	29.13 ms
Size	2.92 MiB	3.39 MiB	486.00 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms
`76d1baf`+dirty	1245.00 ms	1257.76 ms	12.76 ms
`9a3ca65`+dirty	1276.40 ms	1279.14 ms	2.74 ms
`52a8031`+dirty	1255.96 ms	1273.00 ms	17.04 ms
`70caa60`+dirty	1279.08 ms	1281.54 ms	2.46 ms
`15c80ab`+dirty	1248.41 ms	1251.24 ms	2.83 ms
`d197b5c`+dirty	1234.80 ms	1249.20 ms	14.40 ms

App size

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB
`76d1baf`+dirty	2.92 MiB	3.38 MiB	475.74 KiB
`9a3ca65`+dirty	2.92 MiB	3.37 MiB	464.32 KiB
`52a8031`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`70caa60`+dirty	2.92 MiB	3.39 MiB	486.04 KiB
`15c80ab`+dirty	2.92 MiB	3.39 MiB	481.56 KiB
`d197b5c`+dirty	2.92 MiB	3.37 MiB	464.41 KiB

github-actions · 2023-03-27T18:46:12Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	269.81 ms	331.67 ms	61.86 ms
Size	7.15 MiB	8.03 MiB	901.67 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	262.98 ms	311.02 ms	48.04 ms
`8900e1a`+dirty	371.40 ms	377.70 ms	6.31 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms
`76d1baf`+dirty	339.02 ms	408.65 ms	69.63 ms
`9a3ca65`+dirty	344.96 ms	358.92 ms	13.96 ms
`52a8031`+dirty	330.72 ms	358.76 ms	28.03 ms
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms
`15c80ab`+dirty	276.38 ms	327.54 ms	51.17 ms
`d197b5c`+dirty	258.75 ms	313.61 ms	54.86 ms

App size

Revision	Plain	With Sentry	Diff
`e73f4ed`+dirty	7.15 MiB	8.09 MiB	965.94 KiB
`8900e1a`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB
`76d1baf`+dirty	7.15 MiB	8.09 MiB	964.41 KiB
`9a3ca65`+dirty	7.15 MiB	8.09 MiB	962.83 KiB
`52a8031`+dirty	7.15 MiB	8.09 MiB	965.95 KiB
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`15c80ab`+dirty	7.15 MiB	8.09 MiB	966.13 KiB
`d197b5c`+dirty	7.15 MiB	8.09 MiB	962.72 KiB

Previous results on branch: kw-enable-tracing-option

Startup times

Revision	Plain	With Sentry	Diff
`df67025`+dirty	279.49 ms	343.91 ms	64.42 ms

App size

Revision	Plain	With Sentry	Diff
`df67025`+dirty	7.15 MiB	8.03 MiB	901.79 KiB

marandaneto · 2023-03-28T07:34:06Z

sample-new-architecture/src/App.tsx

@@ -61,6 +61,7 @@ Sentry.init({
  // For testing, session close when 5 seconds (instead of the default 30) in the background.
  sessionTrackingIntervalMillis: 5000,
  // This will capture ALL TRACES and likely use up all your quota
+  enableTracing: true,


In this case you dont need tracesSampleRate: 1.0,?

Yes, correct. I just left it to explicitly see that it's 1..

marandaneto

Left a comment, otherwise LGTM

CHANGELOG.md

feat(tracing): Add enableTracing option

250e85b

krystofwoldrich requested a review from marandaneto as a code owner March 27, 2023 17:44

Add the option to the sample app

63f56c7

marandaneto reviewed Mar 28, 2023

View reviewed changes

marandaneto approved these changes Mar 28, 2023

View reviewed changes

Fix lint

c78a07b

krystofwoldrich commented Mar 28, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

krystofwoldrich added 2 commits March 28, 2023 13:48

Update CHANGELOG.md

c8c0f65

Merge branch 'main' into kw-enable-tracing-option

3084d1c

krystofwoldrich merged commit b1a6c2e into main Mar 29, 2023

krystofwoldrich deleted the kw-enable-tracing-option branch March 29, 2023 09:21

krystofwoldrich mentioned this pull request Jan 18, 2024

fix(tracing): Performance Tracing should be disabled by default #3533

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tracing): Add `enableTracing` option #2933

feat(tracing): Add `enableTracing` option #2933

krystofwoldrich commented Mar 27, 2023

github-actions bot commented Mar 27, 2023 •

edited

Loading

github-actions bot commented Mar 27, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-enable-tracing-option

Startup times

App size

github-actions bot commented Mar 27, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-enable-tracing-option

Startup times

App size

github-actions bot commented Mar 27, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Mar 27, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-enable-tracing-option

Startup times

App size

marandaneto Mar 28, 2023

krystofwoldrich Mar 28, 2023 •

edited

Loading

marandaneto left a comment

feat(tracing): Add enableTracing option #2933

feat(tracing): Add enableTracing option #2933

Conversation

krystofwoldrich commented Mar 27, 2023

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Mar 27, 2023 • edited Loading

github-actions bot commented Mar 27, 2023 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-enable-tracing-option

Startup times

App size

github-actions bot commented Mar 27, 2023 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-enable-tracing-option

Startup times

App size

github-actions bot commented Mar 27, 2023 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Mar 27, 2023 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-enable-tracing-option

Startup times

App size

marandaneto Mar 28, 2023

Choose a reason for hiding this comment

krystofwoldrich Mar 28, 2023 • edited Loading

Choose a reason for hiding this comment

marandaneto left a comment

Choose a reason for hiding this comment

feat(tracing): Add `enableTracing` option #2933

feat(tracing): Add `enableTracing` option #2933

github-actions bot commented Mar 27, 2023 •

edited

Loading

github-actions bot commented Mar 27, 2023 •

edited

Loading

github-actions bot commented Mar 27, 2023 •

edited

Loading

github-actions bot commented Mar 27, 2023 •

edited

Loading

github-actions bot commented Mar 27, 2023 •

edited

Loading

krystofwoldrich Mar 28, 2023 •

edited

Loading