Add expo, hermes version, react_native_version to react_native_context #3050

krystofwoldrich · 2023-05-08T11:18:39Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Add expo, hermes version, react_native_version to react_native_context.

💡 Motivation and Context

This helps both us and our customers to debug issues.

💚 How did you test it?

sample app, expo app -> https://github.com/krystofwoldrich/sentry-expo-bare-sample-app

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2023-05-08T11:43:22Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	374.04 ms	384.33 ms	10.28 ms
Size	17.73 MiB	19.76 MiB	2.03 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	335.72 ms	355.52 ms	19.80 ms
`80b2ce3`	385.02 ms	387.36 ms	2.34 ms
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`d197b5c`+dirty	338.94 ms	354.87 ms	15.93 ms
`86d6d2c`+dirty	332.90 ms	352.45 ms	19.55 ms
`acadc0f`+dirty	373.24 ms	381.51 ms	8.27 ms
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms
`b1e8712`	462.11 ms	465.71 ms	3.60 ms
`d0bf494`+dirty	375.37 ms	395.14 ms	19.77 ms

App size

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`80b2ce3`	17.73 MiB	19.75 MiB	2.02 MiB
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`d197b5c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`86d6d2c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`acadc0f`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`b1e8712`	17.73 MiB	19.75 MiB	2.02 MiB
`d0bf494`+dirty	17.73 MiB	19.75 MiB	2.02 MiB

github-actions · 2023-05-08T11:53:43Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1229.58 ms	1232.66 ms	3.08 ms
Size	2.36 MiB	2.85 MiB	496.22 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	1244.10 ms	1268.52 ms	24.42 ms
`15c80ab`+dirty	1223.74 ms	1228.96 ms	5.22 ms
`d197b5c`+dirty	1217.61 ms	1242.66 ms	25.05 ms
`86d6d2c`+dirty	1267.55 ms	1286.21 ms	18.66 ms
`acadc0f`+dirty	1264.38 ms	1290.06 ms	25.68 ms
`52a8031`+dirty	1280.88 ms	1289.78 ms	8.90 ms
`70caa60`+dirty	1218.27 ms	1230.30 ms	12.03 ms
`d0bf494`+dirty	1289.40 ms	1298.40 ms	9.00 ms
`d7401ac`+dirty	1252.38 ms	1275.04 ms	22.66 ms
`80b2ce3`+dirty	1265.92 ms	1268.60 ms	2.69 ms

App size

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	2.36 MiB	2.82 MiB	469.45 KiB
`15c80ab`+dirty	2.36 MiB	2.83 MiB	474.49 KiB
`d197b5c`+dirty	2.36 MiB	2.82 MiB	462.86 KiB
`86d6d2c`+dirty	2.36 MiB	2.82 MiB	462.82 KiB
`acadc0f`+dirty	2.36 MiB	2.83 MiB	480.37 KiB
`52a8031`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`70caa60`+dirty	2.36 MiB	2.83 MiB	479.27 KiB
`d0bf494`+dirty	2.36 MiB	2.83 MiB	481.15 KiB
`d7401ac`+dirty	2.36 MiB	2.83 MiB	481.14 KiB
`80b2ce3`+dirty	2.36 MiB	2.84 MiB	486.98 KiB

github-actions · 2023-05-08T11:57:25Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1285.84 ms	1286.76 ms	0.92 ms
Size	2.92 MiB	3.41 MiB	499.49 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	1245.00 ms	1257.76 ms	12.76 ms
`15c80ab`+dirty	1248.41 ms	1251.24 ms	2.83 ms
`d197b5c`+dirty	1234.80 ms	1249.20 ms	14.40 ms
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms
`acadc0f`+dirty	1271.12 ms	1272.28 ms	1.16 ms
`52a8031`+dirty	1255.96 ms	1273.00 ms	17.04 ms
`70caa60`+dirty	1279.08 ms	1281.54 ms	2.46 ms
`d0bf494`+dirty	1266.20 ms	1267.52 ms	1.32 ms
`d7401ac`+dirty	1288.10 ms	1289.54 ms	1.44 ms
`80b2ce3`+dirty	1245.12 ms	1262.04 ms	16.92 ms

App size

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	2.92 MiB	3.38 MiB	475.74 KiB
`15c80ab`+dirty	2.92 MiB	3.39 MiB	481.56 KiB
`d197b5c`+dirty	2.92 MiB	3.37 MiB	464.41 KiB
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB
`acadc0f`+dirty	2.92 MiB	3.39 MiB	487.34 KiB
`52a8031`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`70caa60`+dirty	2.92 MiB	3.39 MiB	486.04 KiB
`d0bf494`+dirty	2.92 MiB	3.40 MiB	488.08 KiB
`d7401ac`+dirty	2.92 MiB	3.40 MiB	488.06 KiB
`80b2ce3`+dirty	2.92 MiB	3.40 MiB	492.75 KiB

github-actions · 2023-05-08T12:14:55Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	323.06 ms	347.76 ms	24.69 ms
Size	7.15 MiB	8.05 MiB	920.93 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	339.02 ms	408.65 ms	69.63 ms
`15c80ab`+dirty	276.38 ms	327.54 ms	51.17 ms
`d197b5c`+dirty	258.75 ms	313.61 ms	54.86 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms
`acadc0f`+dirty	259.04 ms	304.67 ms	45.63 ms
`52a8031`+dirty	330.72 ms	358.76 ms	28.03 ms
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms
`d0bf494`+dirty	253.73 ms	308.23 ms	54.49 ms
`d7401ac`+dirty	373.98 ms	394.08 ms	20.10 ms
`80b2ce3`+dirty	271.29 ms	316.47 ms	45.18 ms

App size

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	7.15 MiB	8.09 MiB	964.41 KiB
`15c80ab`+dirty	7.15 MiB	8.09 MiB	966.13 KiB
`d197b5c`+dirty	7.15 MiB	8.09 MiB	962.72 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB
`acadc0f`+dirty	7.15 MiB	8.03 MiB	903.20 KiB
`52a8031`+dirty	7.15 MiB	8.09 MiB	965.95 KiB
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`d0bf494`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`d7401ac`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`80b2ce3`+dirty	7.15 MiB	8.04 MiB	911.02 KiB

test/integrations/reactnativeinfo.test.ts

krystofwoldrich and others added 4 commits May 7, 2023 21:42

Add ReactNativeVersion to react native info

e3d8b73

feat(rn): Add expo, rn and hermes version to event rn context

2b15988

Fix lint

148d9b9

Fix tests

c568299

krystofwoldrich requested a review from marandaneto as a code owner May 8, 2023 11:18

krystofwoldrich changed the title ~~Add ReactNativeVersion to react native info~~ Add expo, hermes version, react_native_version to react_native_context May 8, 2023

Merge branch 'main' into kw-react-native-context-update

28b06e4

marandaneto reviewed May 9, 2023

View reviewed changes

test/integrations/reactnativeinfo.test.ts Show resolved Hide resolved

marandaneto approved these changes May 9, 2023

View reviewed changes

krystofwoldrich mentioned this pull request May 12, 2023

Add expo flag to react_native_context #3022

Closed

Fix changelog and add hermes version test

28063c9

krystofwoldrich enabled auto-merge (squash) May 12, 2023 15:01

krystofwoldrich merged commit 1652677 into main May 12, 2023

krystofwoldrich deleted the kw-react-native-context-update branch May 12, 2023 15:11

krystofwoldrich mentioned this pull request May 19, 2023

Add Expo RewriteFrames to sentry-react-native to better support Expo Bare workflow #3081

Closed

krystofwoldrich mentioned this pull request Jun 5, 2023

Expo support improvements #3102

Closed

krystofwoldrich self-assigned this Jun 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add expo, hermes version, react_native_version to react_native_context #3050

Add expo, hermes version, react_native_version to react_native_context #3050

krystofwoldrich commented May 8, 2023

github-actions bot commented May 8, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented May 8, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented May 8, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented May 8, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Add expo, hermes version, react_native_version to react_native_context #3050

Add expo, hermes version, react_native_version to react_native_context #3050

Conversation

krystofwoldrich commented May 8, 2023

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented May 8, 2023 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented May 8, 2023 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented May 8, 2023 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented May 8, 2023 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented May 8, 2023 •

edited

Loading

github-actions bot commented May 8, 2023 •

edited

Loading

github-actions bot commented May 8, 2023 •

edited

Loading

github-actions bot commented May 8, 2023 •

edited

Loading