-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): 🌟 add support for React Native 0.73 #3133
Conversation
@peterlazar1993 Thank you for the PR. Before we merge, we need to make sure this is compatible with our min-supported RN version 0.65.3. |
Do you folks really need to support RN down to 0.65.3? |
@fabiendem For the |
You can make that compatible by doing this https://github.com/getsentry/sentry-dart/blob/ddc97adb5918b9f9eda573656e6edd9401b17801/flutter/android/build.gradle#L27-L30 |
@marandaneto Awesome, thank you for sharing that. |
RN 0.65.0 shipped with AGP 4.2.1 so we actually can just add the namespace it should not be a problem. |
Based on this comment from the RN proposal we will have to keep the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @peterlazar1993 for the PR.
hey @krystofwoldrich. We have upgraded our react-native version to 0.72.1 and Sentry started throwing an error during the Android app build because of the missing namespace. When is the next release planned? |
@anurag-hugo The next release will be in the upcoming days. |
📢 Type of change
💡 Motivation and Context
Starting from React Native v0.73 , all libraries will need to be updated with namespace due to the upgrade to AGP 8
react-native-community/discussions-and-proposals#671
💚 How did you test it?
I tested the changes on RN 0.71.11 and everything works!
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps