-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(profiling): Add Native iOS profiles to Hermes JS profiles #3349
Conversation
…symbolicated-profiles
…symbolicated-profiles
…symbolicated-profiles
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple quick things from me!
Co-authored-by: Andrew McKnight <[email protected]> Co-authored-by: LucasZF <[email protected]>
@armcknight @lucas-zimerman Thank you for the feedback. I've adjusted to code, can you take one more look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native code changes in this PR look good, nice work.
I noticed some preexisting code not covered in the diff, so I couldn't comment directly on it, but is this macro left undefined in the main
branch, and you just define it to 1
if you're debugging locally?
sentry-react-native/ios/RNSentry.mm
Line 625 in cbb32a7
#if SENTRY_PROFILING_DEBUG_ENABLED |
@armcknight Yes, exactly. |
📢 Type of change
📜 Description
This PR adds native iOS profiles to currently existing RN Hermes profiles.
Hermes and Native profiles are merged on a device and sent as one profiling event in the envelope with associated Transaction.
💡 Motivation and Context
platform
field to profile frames relay#2629💚 How did you test it?
sample app, unit tests
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps