test(ts3.8): fix ts3.8 type check test to not include dom types #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
requested review from
lucas-zimerman and
antonis
as code owners
krystofwoldrich
commented
Nov 6, 2024
| @@ -9,7 +9,7 @@ | |||
| }, | |||
| "license": "MIT", | |||
| "devDependencies": { | |||
| "@types/react": "17.0.58", | |||
| "@types/react": "17.0.83", | |||
There was a problem hiding this comment.
This is has to to match with dependency of the react native types.
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ac41368 | 451.47 ms | 453.67 ms | 2.20 ms |
| 76d1baf+dirty | 335.72 ms | 355.52 ms | 19.80 ms |
| b1e8712 | 462.11 ms | 465.71 ms | 3.60 ms |
| c2a4e9b | 480.42 ms | 485.60 ms | 5.18 ms |
| 0677344 | 327.74 ms | 337.14 ms | 9.40 ms |
| e540498 | 436.26 ms | 433.00 ms | -3.26 ms |
| 3853f43 | 329.68 ms | 346.32 ms | 16.64 ms |
| 5bb8d5f | 431.21 ms | 459.40 ms | 28.19 ms |
| dadc233+dirty | 333.78 ms | 343.94 ms | 10.16 ms |
| 70e6261 | 482.65 ms | 495.70 ms | 13.05 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ac41368 | 17.73 MiB | 20.11 MiB | 2.38 MiB |
| 76d1baf+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| b1e8712 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| c2a4e9b | 17.73 MiB | 20.06 MiB | 2.33 MiB |
| 0677344 | 17.73 MiB | 19.81 MiB | 2.07 MiB |
| e540498 | 17.73 MiB | 20.11 MiB | 2.37 MiB |
| 3853f43 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
| 5bb8d5f | 17.73 MiB | 19.93 MiB | 2.20 MiB |
| dadc233+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| 70e6261 | 17.73 MiB | 19.94 MiB | 2.21 MiB |
krystofwoldrich
changed the title
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8900e1a+dirty | 1210.27 ms | 1218.66 ms | 8.39 ms |
| 4cc5c27+dirty | 1211.45 ms | 1214.60 ms | 3.16 ms |
| 1c65324+dirty | 1235.17 ms | 1235.08 ms | -0.09 ms |
| e73d82f+dirty | 1207.52 ms | 1216.73 ms | 9.21 ms |
| 6e8584e+dirty | 1274.50 ms | 1296.82 ms | 22.32 ms |
| 9cab16b+dirty | 1237.76 ms | 1234.00 ms | -3.76 ms |
| baa882f+dirty | 1218.00 ms | 1227.04 ms | 9.04 ms |
| 76d1baf+dirty | 1244.10 ms | 1268.52 ms | 24.42 ms |
| e540498+dirty | 1220.61 ms | 1212.93 ms | -7.68 ms |
| e5c9b8b+dirty | 1258.57 ms | 1267.32 ms | 8.75 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8900e1a+dirty | 2.36 MiB | 2.83 MiB | 479.25 KiB |
| 4cc5c27+dirty | 2.36 MiB | 3.04 MiB | 698.52 KiB |
| 1c65324+dirty | 2.36 MiB | 3.04 MiB | 698.64 KiB |
| e73d82f+dirty | 2.36 MiB | 3.08 MiB | 734.23 KiB |
| 6e8584e+dirty | 2.36 MiB | 2.88 MiB | 533.17 KiB |
| 9cab16b+dirty | 2.36 MiB | 3.08 MiB | 737.23 KiB |
| baa882f+dirty | 2.36 MiB | 3.08 MiB | 731.91 KiB |
| 76d1baf+dirty | 2.36 MiB | 2.82 MiB | 469.45 KiB |
| e540498+dirty | 2.36 MiB | 3.14 MiB | 793.34 KiB |
| e5c9b8b+dirty | 2.36 MiB | 2.87 MiB | 520.43 KiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2534337+dirty | 597.14 ms | 665.04 ms | 67.90 ms |
| 76d1baf+dirty | 339.02 ms | 408.65 ms | 69.63 ms |
| 0677344+dirty | 288.40 ms | 391.44 ms | 103.04 ms |
| d43a46b+dirty | 417.65 ms | 472.98 ms | 55.33 ms |
| e5c9b8b+dirty | 335.40 ms | 360.06 ms | 24.67 ms |
| 9cab16b+dirty | 370.82 ms | 416.37 ms | 45.55 ms |
| 6e8584e+dirty | 383.37 ms | 400.84 ms | 17.47 ms |
| c398f67+dirty | 315.08 ms | 345.60 ms | 30.52 ms |
| dadc233+dirty | 363.19 ms | 370.37 ms | 7.18 ms |
| f06c879+dirty | 361.27 ms | 407.88 ms | 46.61 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2534337+dirty | 7.15 MiB | 8.11 MiB | 988.68 KiB |
| 76d1baf+dirty | 7.15 MiB | 8.09 MiB | 964.41 KiB |
| 0677344+dirty | 7.15 MiB | 8.07 MiB | 949.80 KiB |
| d43a46b+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
| e5c9b8b+dirty | 7.15 MiB | 8.10 MiB | 980.41 KiB |
| 9cab16b+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 6e8584e+dirty | 7.15 MiB | 8.13 MiB | 1002.18 KiB |
| c398f67+dirty | 7.15 MiB | 8.21 MiB | 1.07 MiB |
| dadc233+dirty | 7.15 MiB | 8.04 MiB | 910.84 KiB |
| f06c879+dirty | 7.15 MiB | 8.12 MiB | 997.78 KiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8900e1a+dirty | 1268.36 ms | 1273.04 ms | 4.68 ms |
| 4cc5c27+dirty | 1220.43 ms | 1215.13 ms | -5.30 ms |
| 1c65324+dirty | 1239.71 ms | 1239.86 ms | 0.15 ms |
| e73d82f+dirty | 1231.20 ms | 1228.81 ms | -2.40 ms |
| 6e8584e+dirty | 1271.71 ms | 1281.26 ms | 9.55 ms |
| 9cab16b+dirty | 1236.10 ms | 1247.16 ms | 11.06 ms |
| baa882f+dirty | 1235.48 ms | 1229.02 ms | -6.46 ms |
| 76d1baf+dirty | 1245.00 ms | 1257.76 ms | 12.76 ms |
| e540498+dirty | 1254.92 ms | 1247.21 ms | -7.71 ms |
| e5c9b8b+dirty | 1276.90 ms | 1280.92 ms | 4.02 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8900e1a+dirty | 2.92 MiB | 3.39 MiB | 485.96 KiB |
| 4cc5c27+dirty | 2.92 MiB | 3.61 MiB | 705.47 KiB |
| 1c65324+dirty | 2.92 MiB | 3.61 MiB | 705.56 KiB |
| e73d82f+dirty | 2.92 MiB | 3.64 MiB | 740.56 KiB |
| 6e8584e+dirty | 2.92 MiB | 3.44 MiB | 536.52 KiB |
| 9cab16b+dirty | 2.92 MiB | 3.64 MiB | 743.06 KiB |
| baa882f+dirty | 2.92 MiB | 3.64 MiB | 738.56 KiB |
| 76d1baf+dirty | 2.92 MiB | 3.38 MiB | 475.74 KiB |
| e540498+dirty | 2.92 MiB | 3.69 MiB | 794.14 KiB |
| e5c9b8b+dirty | 2.92 MiB | 3.43 MiB | 524.50 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
This PR changes the type check test project to only include the es2015/es6 types excluding dom, which would cause duplicate declarations when the project would import React or React Native.