Support Rails 7.2 on CI #2382
Merged
Support Rails 7.2 on CI #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2382 +/- ##
==========================================
- Coverage 98.70% 98.69% -0.01%
==========================================
Files 210 210
Lines 13904 13912 +8
==========================================
+ Hits 13724 13731 +7
- Misses 180 181 +1
|
st0012
commented
Aug 17, 2024
| @@ -43,6 +43,9 @@ jobs: | |||
| - { ruby_version: "2.7", rails_version: 5.2.0 } | |||
| - { ruby_version: "2.7", rails_version: 6.0.0 } | |||
| - { ruby_version: "2.7", rails_version: 6.1.0 } | |||
| - { ruby_version: "3.1", rails_version: 7.2.0 } | |||
| - { ruby_version: "3.2", rails_version: 7.2.0 } | |||
| - { ruby_version: "3.3", rails_version: 7.2.0 } | |||
There was a problem hiding this comment.
I know it's ultimately a business decision, but IMO we should drop support or at least stop running CI against Ruby 2.4, 2.5 and Rails 5.0 and 5.1.
Otherwise, with the release of Rails 8.0 in the near future, we'll be running so many jobs on CI for each PR.
There was a problem hiding this comment.
I will prepare a major soon and remove, just need some time since I'm busy with another larger project
sl0thentr0py
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
On my machine, running
sentry-rails's full test suite withrake testagainst Rails 7.1 takes less than 8 seconds. But it now takes ~33 seconds against Rails 7.2 even after I solved the slowdown issue caused by the eager load namespace accumulation issue. That said, I think we can start running tests against Rails 7.2 and optimize the test setup further in another PR.