Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default app dirs pattern #2390

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Set default app dirs pattern #2390

merged 2 commits into from
Sep 1, 2024

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Aug 30, 2024

Instead of falling back to the default app dirs pattern when config.app_dirs_pattern is nil, we can simply set it to APP_DIRS_PATTERN by default.

This means we don't need to always check if config.app_dirs_pattern is set and can simply use it.

Instead of falling back to the default app dirs pattern when `config.app_dirs_pattern`
is `nil`, we can simply set it to `APP_DIRS_PATTERN` by default.

This means we don't need to always check if `config.app_dirs_pattern` is set
and can simply use it.
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (4db5f74) to head (abc80d8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2390      +/-   ##
==========================================
- Coverage   98.69%   98.68%   -0.01%     
==========================================
  Files         210      210              
  Lines       13923    13923              
==========================================
- Hits        13741    13740       -1     
- Misses        182      183       +1     
Components Coverage Δ
sentry-ruby 99.06% <100.00%> (ø)
sentry-rails 97.34% <ø> (ø)
sentry-sidekiq 97.07% <ø> (ø)
sentry-resque 96.79% <ø> (-0.33%) ⬇️
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/backtrace.rb 96.66% <100.00%> (-0.06%) ⬇️
sentry-ruby/lib/sentry/configuration.rb 98.83% <100.00%> (+<0.01%) ⬆️
sentry-ruby/lib/sentry/profiler.rb 99.11% <100.00%> (ø)
sentry-ruby/spec/sentry/backtrace/lines_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/transport_spec.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@st0012 st0012 merged commit 5980531 into master Sep 1, 2024
140 checks passed
@st0012 st0012 deleted the default-app-dirs-pattern branch September 1, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants