-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OptionConfiguration
#1888
base: feat/create-cli-config
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add `OptionConfiguration` ([#1888](https://github.com/getsentry/sentry-unity/pull/1888)) If none of the above apply, you can opt out of this check by adding |
|
||
options.Environment = "dev"; | ||
|
||
options.NativeOverrides.Environment = "native_dev"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a real use case though?
Shouldn't we just take the dev
above and automatically override native?
I see this makes sense for things that only the native layer has though
83d68eb
to
3c7e7b1
Compare
Fixes #1621
Based on the issue description: The aim is to have users no longer need to know or care about
Runtime
andBuildTime
differences. They write their code in once place, we use the same options at any time.If the need arises to set native-specific options - i.e. to set the
sample-rate
on the native layer, we provideNativeOverrides
on the options themselves.The downside (and a possible footgun for us): We need to be careful when modifying or adding options on the native layer to make sure we use the overrides and if those are null, fall back to the actual options.