Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance monitoring API #470
Add performance monitoring API #470
Changes from 28 commits
41588a6
390dd0e
ad583af
ec0c501
79bf971
5424cbc
d6e8f38
17384d9
cf91b7f
0241501
b1cd1ab
36c1525
be52bb7
0b4c328
95498d3
6c7664f
a6172b4
1f06047
a6b8710
54c4922
b040fca
fb8b5ce
4151f3c
6f2d793
69bd7cb
2d9df06
e9b8fd8
c523eef
5a99934
c4eeadb
337b2a1
60af3e3
418d981
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL.
Do you happen to know where this gets filtered? Is that tag still part of the event or does it get removed by the SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on a previous experience with setting extra context for captured events I assume that the "removed" tag is still sent to Sentry however it's not displayed due to its empty value. I wasn't able to find any code in sentry-java that removes it explicitly on the client side but it's hardly confirms my theory