Skip to content

Commit

Permalink
fix tests for pulling logic into helper
Browse files Browse the repository at this point in the history
  • Loading branch information
lobsterkatie committed Jul 30, 2024
1 parent b129c4f commit 4e59667
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions tests/sentry/event_manager/grouping/test_seer_grouping.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ def test_obeys_seer_similarity_flags(self):

with (
patch(
"sentry.event_manager.should_call_seer_for_grouping",
"sentry.grouping.ingest.seer.should_call_seer_for_grouping",
wraps=should_call_seer_for_grouping,
) as should_call_seer_spy,
patch(
"sentry.event_manager.get_seer_similar_issues",
"sentry.grouping.ingest.seer.get_seer_similar_issues",
wraps=capture_results(
get_seer_similar_issues, get_seer_similar_issues_return_values
),
Expand Down Expand Up @@ -83,14 +83,14 @@ def test_obeys_seer_similarity_flags(self):
assert get_seer_similar_issues_return_values[0][1] == existing_event.group
assert new_event.group_id == existing_event.group_id

@patch("sentry.event_manager.should_call_seer_for_grouping", return_value=True)
@patch("sentry.event_manager.get_seer_similar_issues", return_value=({}, None))
@patch("sentry.grouping.ingest.seer.should_call_seer_for_grouping", return_value=True)
@patch("sentry.grouping.ingest.seer.get_seer_similar_issues", return_value=({}, None))
def test_calls_seer_if_no_group_found(self, mock_get_seer_similar_issues: MagicMock, _):
save_new_event({"message": "Dogs are great!"}, self.project)
assert mock_get_seer_similar_issues.call_count == 1

@patch("sentry.event_manager.should_call_seer_for_grouping", return_value=True)
@patch("sentry.event_manager.get_seer_similar_issues", return_value=({}, None))
@patch("sentry.grouping.ingest.seer.should_call_seer_for_grouping", return_value=True)
@patch("sentry.grouping.ingest.seer.get_seer_similar_issues", return_value=({}, None))
def test_bypasses_seer_if_group_found(self, mock_get_seer_similar_issues: MagicMock, _):
existing_event = save_new_event({"message": "Dogs are great!"}, self.project)
assert mock_get_seer_similar_issues.call_count == 1
Expand All @@ -99,7 +99,7 @@ def test_bypasses_seer_if_group_found(self, mock_get_seer_similar_issues: MagicM
assert existing_event.group_id == new_event.group_id
assert mock_get_seer_similar_issues.call_count == 1 # didn't get called again

@patch("sentry.event_manager.should_call_seer_for_grouping", return_value=True)
@patch("sentry.grouping.ingest.seer.should_call_seer_for_grouping", return_value=True)
def test_stores_seer_results_in_metadata(self, _):
existing_event = save_new_event({"message": "Dogs are great!"}, self.project)

Expand All @@ -124,7 +124,7 @@ def test_stores_seer_results_in_metadata(self, _):
assert new_event.data["seer_similarity"] == expected_metadata

@with_feature("projects:similarity-embeddings-grouping")
@patch("sentry.event_manager.should_call_seer_for_grouping", return_value=True)
@patch("sentry.grouping.ingest.seer.should_call_seer_for_grouping", return_value=True)
def test_assigns_event_to_neighbor_group_if_found(self, _):
existing_event = save_new_event({"message": "Dogs are great!"}, self.project)

Expand All @@ -146,7 +146,7 @@ def test_assigns_event_to_neighbor_group_if_found(self, _):
assert existing_event.group_id == new_event.group_id

@with_feature("projects:similarity-embeddings-grouping")
@patch("sentry.event_manager.should_call_seer_for_grouping", return_value=True)
@patch("sentry.grouping.ingest.seer.should_call_seer_for_grouping", return_value=True)
def test_creates_new_group_if_no_neighbor_found(self, _):
existing_event = save_new_event({"message": "Dogs are great!"}, self.project)

Expand Down

0 comments on commit 4e59667

Please sign in to comment.