ref(similarity): Stop sending message in backfill grouping records (#…

…77968) Stop sending group message in record creation call to seer in the backfill
getsentry · Sep 27, 2024 · 5ac32f6 · 5ac32f6
1 parent 8b91034
commit 5ac32f6
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 11 deletions.
diff --git a/src/sentry/seer/similarity/grouping_records.py b/src/sentry/seer/similarity/grouping_records.py
@@ -24,7 +24,6 @@ class CreateGroupingRecordData(TypedDict):
     group_id: int
     hash: str
     project_id: int
-    message: str
     exception_type: str | None
 
 

diff --git a/src/sentry/tasks/embeddings_grouping/utils.py b/src/sentry/tasks/embeddings_grouping/utils.py
@@ -374,7 +374,6 @@ def get_events_from_nodestore(
                 CreateGroupingRecordData(
                     group_id=group_id,
                     project_id=project.id,
-                    message=filter_null_from_string(event.title),
                     exception_type=(
                         filter_null_from_string(exception_type) if exception_type else None
                     ),

diff --git a/tests/sentry/seer/similarity/test_grouping_records.py b/tests/sentry/seer/similarity/test_grouping_records.py
@@ -26,14 +26,12 @@
             "group_id": 1,
             "hash": "hash-1",
             "project_id": 1,
-            "message": "message",
             "exception_type": "Error",
         },
         {
             "group_id": 2,
             "hash": "hash-2",
             "project_id": 1,
-            "message": "message 2",
             "exception_type": "Error",
         },
     ],

diff --git a/tests/sentry/tasks/test_backfill_seer_grouping_records.py b/tests/sentry/tasks/test_backfill_seer_grouping_records.py
@@ -183,7 +183,6 @@ def test_lookup_group_data_stacktrace_bulk_success(self, mock_metrics):
                 group_id=event.group.id,
                 hash=self.group_hashes[event.group.id],
                 project_id=self.project.id,
-                message=event.title,
                 exception_type=get_path(event.data, "exception", "values", -1, "type"),
             )
             for event in events
@@ -212,7 +211,6 @@ def test_lookup_group_data_stacktrace_bulk_success_multithread(self, mock_metric
                 group_id=event.group.id,
                 hash=self.group_hashes[event.group.id],
                 project_id=self.project.id,
-                message=event.title,
                 exception_type=get_path(event.data, "exception", "values", -1, "type"),
             )
             for event in events
@@ -282,7 +280,6 @@ def test_lookup_group_data_stacktrace_bulk_not_stacktrace_grouping(self):
                 group_id=event.group.id,
                 hash=hashes[event.group.id],
                 project_id=self.project.id,
-                message=event.title,
                 exception_type=get_path(event.data, "exception", "values", -1, "type"),
             )
             for event in events
@@ -317,7 +314,6 @@ def test_lookup_group_data_stacktrace_bulk_no_stacktrace_exception(self):
                 group_id=event.group.id,
                 hash=hashes[event.group.id],
                 project_id=self.project.id,
-                message=event.title,
                 exception_type=get_path(event.data, "exception", "values", -1, "type"),
             )
             for event in events
@@ -345,7 +341,6 @@ def test_lookup_group_data_stacktrace_bulk_with_fallback_success(self):
                 group_id=event.group.id,
                 hash=hashes[event.group.id],
                 project_id=self.project.id,
-                message=event.title,
                 exception_type=get_path(event.data, "exception", "values", -1, "type"),
             )
             for event in events
@@ -383,7 +378,6 @@ def test_lookup_group_data_stacktrace_bulk_with_fallback_use_single_fallback(
                 group_id=event.group.id,
                 hash=hashes[event.group.id],
                 project_id=self.project.id,
-                message=event.title,
                 exception_type=get_path(event.data, "exception", "values", -1, "type"),
             )
             for event in events
@@ -418,7 +412,6 @@ def test_lookup_group_data_stacktrace_bulk_with_fallback_event_lookup_error(self
                 group_id=event.group.id,
                 hash=hashes[event.group.id],
                 project_id=self.project.id,
-                message=event.title,
                 exception_type=get_path(event.data, "exception", "values", -1, "type"),
             )
             for event in events