Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolicate Flutter issue's title #48334

Open
marandaneto opened this issue May 2, 2023 · 21 comments
Open

Symbolicate Flutter issue's title #48334

marandaneto opened this issue May 2, 2023 · 21 comments

Comments

@marandaneto
Copy link
Contributor

Problem Statement

https://docs.sentry.io/platforms/flutter/troubleshooting/#known-limitations

Issue titles might be obfuscated as we rely on the runtimeType, but they may not be human-readable. See the Obfuscate Caveat.

The issue's title is still obfuscated even if uploading debug symbols and symbolicating the error.

Solution Brainstorm

We can infer the title from the exception list, similarly to how Java does.
https://github.com/getsentry/sentry/blob/master/src/sentry/lang/java/processing.py#L6

Product Area

Issues

@kahest

This comment has been minimized.

@aprzedecki
Copy link

is it doable in the nearest future ?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@ioanniskouts
Copy link

Any updates on this? It will save us some time if we have this feature and might also help with the issues grouping.

@marandaneto
Copy link
Contributor Author

@ioanniskouts is in the plan but I don't have a timeline, this won't affect grouping though, it's only about the issue's title.
The stack trace frames are already symbolicated.

@aprzedecki
Copy link

There seem to be a bigger issue with that - each release is a new build, which regenerated all symbols that have different obfuscation values. This causes that existing issues are duplicated and maintaining the project becomes very time consuming to merge again and again the same issues. Is there any solution for that ?

@marandaneto
Copy link
Contributor Author

@aprzedecki issues are grouped per stack trace by default, and grouping happens after symbolication, this isn't related to this issue (this is just about the title).
In case you are facing grouping problems, please raise a new issue with more context (eg links of 2 different issues that should be grouped together but are not).

@aprzedecki
Copy link

Ok, thanks for clearing up.

@marandaneto
Copy link
Contributor Author

This is not possible on Flutter web, See https://github.com/dart-lang/sdk/blob/master/pkg/compiler/doc/sourcemap_extensions.md#global-minified-names
The source maps contain only the minified types but not the damangled ones.
The frames also don't contain the type, but rather the filename and function only.
In this case, showing the function and filename/module would be already better but it's not possible to map the right frame from the minified type.

We'll need to address dart-lang/sdk#51941 first which is being able to upload the generated file from (--extra-gen-snapshot-options=--save-obfuscation-map=mapping.json) and then demangle the type based on the mappings.json.

I'll check AOT compiled apps now.

@marandaneto
Copy link
Contributor Author

Found an alternative for AOT apps, See dart-lang/sdk#51941 (comment)
This has to be implemented on the Sentry SDK first, sentry-cli, Sentry Dart plugin, and Sentry itself first, which is a way bigger scope than actually planned, I will talk internally about this investment.

@aprzedecki
Copy link

@marandaneto any news on this one ?

@kahest
Copy link
Member

kahest commented Jan 4, 2024

Hey @aprzedecki, thanks for your interest - we don't have definite plans or a timeline at the moment. cc @buenaflor

@ioanniskouts
Copy link

@kahest do you guys have any update on this? Thanks

@kahest
Copy link
Member

kahest commented Mar 19, 2024

Hey @ioanniskouts nothing definite at the moment, we'll keep you posted!

@metafounder
Copy link

Any update on this?

@EmmanuelAdeiza
Copy link

Any update on this please?

@kahest
Copy link
Member

kahest commented Apr 17, 2024

Please see above - we plan to tackle this but don't have a concrete ETA yet. We're keeping this issue up to date as things develop.

@Masadow
Copy link

Masadow commented Jun 12, 2024

While this issue is resolved, what is the current workaround to troubleshoot issue like this ?

type 'minified:a6o' is not a subtype of type 'minified:dH'

The deobfuscated stack trace might not be enough without knowing which types are causing trouble

@getsantry
Copy link
Contributor

getsantry bot commented Jun 14, 2024

Routing to @getsentry/product-owners-issues-source-maps for triage ⏲️

@buenaflor
Copy link
Contributor

@Masadow could you share a link to the event to [email protected] please

@kahest
Copy link
Member

kahest commented Jul 29, 2024

Update: we merged an improvement to mitigate this issue for well-known exception types, will be available with the next release. cc @buenaflor

Edit: Read our changelog entry for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Status: Backlog
Development

No branches or pull requests

10 participants