-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide misleading source context errors from Dart/Flutter SDK for Flutter Web #1764
Comments
@lforst do you have a suggestion on how to approach this - do we just conditionally hide it if they're not relevant? Also feel free to tag someone else who knows better |
@loewenheim I feel like symbolicator should not be emitting the error here. Looks like everything got mapped correctly. I'd assume flutter web uses inline-source maps. |
@lforst release builds generate a sourcemap that we also upload example: |
Just saw that the source maps references always point to main.dart.js.map. Generally speaking all js files need to have their own .map files. This looks off. |
Hm, this is the only sourcemap generated by flutter, what do you think about disabling the error messages manually for now until we can investigate this more? It's pretty bad for the ux currently |
If the error messages are not actionable, not informative or even wrong we should hide them for sure! |
Closing - this issue is now fixed, these errors do not appear anymore |
@momrak thx for the report, I'll try to repo but it looks like we should also ignore these in the event page |
Is it possible to upload these source maps to get better error messages here, or is this related to getsentry/sentry#48334 and can first be fixed once that is done? |
I also uploaded my source map for flutter web, made sure release and dist match but I keep seeing the I have tried uploading the source maps both manually and using the dart sentry plugin. Both methods do upload the source map into the project on sentry, I have verified that, |
Hi @thomasmechessa891 , do you have a link to an example I can look at? |
I can create another empty flutter project and share a link. Would that work for you? |
Sure, that would work! |
Description
source context is automatically enabled on Flutter web when using the
sentry_dart_plugin
.When correctly using the plugin it will upload sourcemaps and sources which leads to the source code of the own app displayed inbetween minified third party package code.
However, the issue will still show misleading
missing_source_context
errors which are irrelevant because they refer to sources not from inApp but the flutter/dart sdk.The text was updated successfully, but these errors were encountered: