Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Team Admin - Debug Symbols cannot be removed from project settings #53919

Closed
Angelodaniel opened this issue Aug 1, 2023 · 3 comments · Fixed by #56148
Closed

Team Admin - Debug Symbols cannot be removed from project settings #53919

Angelodaniel opened this issue Aug 1, 2023 · 3 comments · Fixed by #56148
Labels
Product Area: Settings - Teams

Comments

@Angelodaniel
Copy link
Member

Angelodaniel commented Aug 1, 2023 •
edited
Loading

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Log in as a team admin
  2. Go to project with debug symbols uploaded
  3. Try to remove one of the symbols

Expected Result

I would expect to delete the debug symbols because of the team admin role my user has like mentioned in the banner on the top of the first screenshot

Actual Result

Screenshot 2023-08-01 at 10 11 12 Screenshot 2023-08-01 at 10 11 28 Screenshot 2023-08-01 at 10 11 34

Product Area

Settings

Link

https://super-mario.sentry.io/settings/projects/chaos-planner/

DSN

No response

Version

No response
@Dhrumil-Sentry
Copy link

Hi @Angelodaniel - Thanks a for raising- Team Admins should be allowed to do this- @leedongwei something for us to fix

@getsantry
Copy link
Contributor

getsantry bot commented Aug 2, 2023

Routing to @getsentry/product-owners-settings-teams for triage ⏲️

@Dhrumil-Sentry Dhrumil-Sentry mentioned this issue Sep 11, 2023
Closed
@Dhrumil-Sentry
Copy link

@leedongwei another issue that asks for team admin access to debug files: #55975

This was referenced Sep 12, 2023
Merged
Merged
schew2381 added a commit that referenced this issue Sep 13, 2023
@schew2381
feat(permissions): Allow team admins to call delete debug file endpoi…
d9b917e 
…nt (#56148)

Frontend Changes: #56123

Allow team admins to delete debug files through the endpoint

Fixes #53919
schew2381 added a commit that referenced this issue Sep 13, 2023
@schew2381
fix(UI): Let team admin add built-in/custom repos + delete debug files (
00774a3 
#56123)

Requires #56148 - backend changes to let team admins delete debug files

In order to check the write access for Team Admins, I need the full project. Originally we were drilling down the project slug instead of the project itself, so I changed it to pass the full project for built-in + custom repo components

For Debug files, project was not being passed at all so I added it.

Recording of a Team Admin (unable to delete debug file because backend
changes are in other PR)

https://github.com/getsentry/sentry/assets/67301797/98d2ee1d-67f7-415b-909d-f64fb2b82e7c

Fixes #56116 and
#53919
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Product Area: Settings - Teams
Projects
GitHub Issues with 👀
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(permissions): Allow team admins to call delete debug file endpoint getsentry/sentry
2 participants
@Angelodaniel @Dhrumil-Sentry