Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Replay Details - Bug] pausing should set proper video.currentTime #68111

Closed
Tracked by #63255
michellewzhang opened this issue Apr 2, 2024 · 0 comments · Fixed by #68212
Closed
Tracked by #63255

[Replay Details - Bug] pausing should set proper video.currentTime #68111

michellewzhang opened this issue Apr 2, 2024 · 0 comments · Fixed by #68212

Comments

@michellewzhang
Copy link
Member

michellewzhang commented Apr 2, 2024 •
edited
Loading

we aren't currently setting the proper video.currentTime due to range header limitations. this leads to a couple bugs:

so clicking from 0-5 seconds will always show the frame at 0, clicking from 6-10 will always show the frame at 6, etc

Screen.Recording.2024-04-02.at.12.29.49.PM.mov
@michellewzhang michellewzhang mentioned this issue Apr 2, 2024
Open
@michellewzhang michellewzhang changed the title [Replay Details] Seeking while paused should show correct frame preview [Replay Details - Bug] Seeking while paused should show correct frame preview Apr 2, 2024
@michellewzhang michellewzhang changed the title [Replay Details - Bug] Seeking while paused should show correct frame preview [Replay Details - Bug] Seeking while paused or pausing in general should show correct frame preview Apr 2, 2024
@michellewzhang michellewzhang changed the title [Replay Details - Bug] Seeking while paused or pausing in general should show correct frame preview [Replay Details - Bug] Seeking while paused or pausing in general should show correct frame preview and set proper video.currentTime Apr 3, 2024
@michellewzhang michellewzhang changed the title [Replay Details - Bug] Seeking while paused or pausing in general should show correct frame preview and set proper video.currentTime [Replay Details - Bug] pausing should set proper video.currentTime Apr 3, 2024
This was referenced Apr 3, 2024
Closed
Closed
Merged
@billyvg billyvg closed this as completed in df944b2 Apr 4, 2024
shellmayr pushed a commit that referenced this issue Apr 10, 2024
@billyvg @michellewzhang
@ryan953 @getsantry @shellmayr
feat(replay): Add "buffering" state for mobile replays (#68212)
d20e50a 
Adds a buffering state for mobile replays to show a "Buffering" messages
when it is busy. Also fixes some timer syncing issues when buffering/not
ready.

- Fixes #67727
- Fixes #67712
- Fixes #68111


To test locally: change `PRELOAD_BUFFER` in `videoReplayer` from "3" to
"1"
To test on preview deployment: change browser throttling to 3g *after*
Sentry UI has loaded and before you play the replay:


![image](https://github.com/getsentry/sentry/assets/79684/0b165bce-e2c3-4417-a6ef-e00887dd3c1f)


Preview (via removing preload):

[Screen Recording 2024-04-03 at
17.11.59.mov](https://github.com/getsentry/sentry/assets/79684/775f4006-8c6c-4acd-9e69-f833a29e43e9)

---------

Co-authored-by: Michelle Zhang <[email protected]>
Co-authored-by: Ryan Albrecht <[email protected]>
Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(replay): Add "buffering" state for mobile replays getsentry/sentry
1 participant
@michellewzhang