Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(ui): Upgrade jest, jest-junit #32132

Merged
merged 3 commits into from
Mar 1, 2022
Merged

deps(ui): Upgrade jest, jest-junit #32132

merged 3 commits into from
Mar 1, 2022

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Feb 28, 2022

Jest is working towards releasing v28 so this puts us on the latest version of 27

@JonasBa
Copy link
Member

JonasBa commented Mar 1, 2022

@scttcper we should run a quick benchmark of the test suites before merging this. The reason is that lots of people have been saying that there seems to have been slight regressions in v27 (jestjs/jest#7963). If those are sufficiently large for our project, we should maybe reconsider merging (altho looks like all of our tests pass, so maybe there's no impact)

@scttcper
Copy link
Member Author

scttcper commented Mar 1, 2022

@JonasBa we're already on v27. Do the comments say it's the later versions or any version

@scttcper scttcper merged commit 9fe4d37 into master Mar 1, 2022
@scttcper scttcper deleted the scttcper/upgrade-jest branch March 1, 2022 16:58
@JonasBa
Copy link
Member

JonasBa commented Mar 1, 2022

@scttcper oh my bad. I looked at the @types/jest diff which was still on 26...

@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants