fix(github-invite): use sql for missing members API to utilize db indices #56911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
dashed
reviewed
Sep 26, 2023
Co-authored-by: Alberto Leal <[email protected]>
cathteng
commented
Sep 26, 2023
| for filtered_email in filtered_email_domains: | ||
| additional_query += f"""and email not like '%{filtered_email}' """ | ||
|
|
||
| query = f""" |
There was a problem hiding this comment.
todo: this query doesn't include the relation to the org member set, but somehow tests are all passing
JoshFerge
reviewed
Sep 27, 2023
| .annotate(Count("commit")) | ||
| .order_by("-commit__count") | ||
| ) | ||
| def _get_missing_organization_members_query( |
There was a problem hiding this comment.
worth looking into if its better to write raw SQL or trying to use SubQuery django stuff etc. e.g.
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
cathteng
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use SQL to better utilize db indices to improve the performance of the API. Attempts to fix SENTRY-161D.
Existing indices
Commit:("repository_id", "date_added")CommitAuthordoesn't have an index on external_id, but if we filter on it after using a subquery, it's already filtered.Also removes querying for commit author
external_idand/oremailbecause we don't surface this anywhere on the FE.