Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(ui): Upgrade react-lazyload #68852

Merged
merged 2 commits into from
Apr 15, 2024
Merged

deps(ui): Upgrade react-lazyload #68852

merged 2 commits into from
Apr 15, 2024

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Apr 14, 2024

Silences warning about react 18 peer dependency.
I think the breaking major version is an extra div wrapper.

3.0.0 fixes the findDomNode warning through usage of React ref, and the following are the changes you need to be aware of
Now we have an extra div wrapping the lazy loaded component for the React ref to work
We can understand that it is an extra DOM node, and we are working to optimize that if possible
It might break your UI or snapshot tests based on your usage
To customize the styling to the extra div please refer here
Found any other problem, please feel free to leave a comment over twobin/react-lazyload#310

the types are pretty simple https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-lazyload/index.d.ts

Silences warning about react 18 peer dependency.
I think the breaking major version is an extra div wrapper.
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 14, 2024
Copy link

codecov bot commented Apr 14, 2024

Bundle Report

Changes will decrease total bundle size by 34.43kB ⬇️

Bundle name Size Change
sentry-webpack-bundle-array-push 26.27MB 34.43kB ⬇️

@scttcper scttcper marked this pull request as ready for review April 15, 2024 16:58
@scttcper scttcper requested a review from a team as a code owner April 15, 2024 16:58
@scttcper scttcper requested a review from a team April 15, 2024 16:58
@scttcper scttcper merged commit e363ddd into master Apr 15, 2024
39 checks passed
@scttcper scttcper deleted the scttcper/react-lazyload branch April 15, 2024 17:22
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants