ref: fix typing for event_id (it is str) #72718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
asottile-sentry
commented
Jun 13, 2024
| @@ -28,7 +28,7 @@ def trace_connected_analysis( | |||
| if event_id: | |||
| # If we are passing an specific event_id, we need to get the project_id | |||
| assert project_id is not None | |||
| event = eventstore.backend.get_event_by_id(project_id, event_id, group_id=group.id) | |||
| event = eventstore.backend.get_event_by_id(int(project_id), event_id, group_id=group.id) | |||
There was a problem hiding this comment.
@armenzg is going to handle the api endpoint doing the validation itself instead of here so this int(...) call should go away eventually (and the extra_args would probably become a TypedDict or normal parameters)
armenzg
approved these changes
Jun 13, 2024
split out from my Job is TypedDict branch
asottile-sentry
force-pushed
the
asottile-event-id-is-str
branch
from
0f6431f
to
4ff7ea8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split out from my Job is TypedDict branch