ref: fix some types for sentry.issues #72813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
asottile-sentry
commented
Jun 14, 2024
| @@ -70,7 +72,7 @@ def get( | |||
| ).values_list("id", flat=True) | |||
| ) | |||
|
|
|||
| union_qs = Activity.objects.none() | |||
| union_qs = Activity.objects.none().values_list("id", flat=True) | |||
There was a problem hiding this comment.
this convinces mypy the type is QuerySet[Activity, int]
joshuarli
reviewed
Jun 14, 2024
| @@ -110,6 +110,7 @@ def post(self, request: Request, organization: Organization) -> Response: | |||
| sort=result["sort"], | |||
| visibility=result["visibility"], | |||
| ) | |||
| assert saved_search.type is not None | |||
There was a problem hiding this comment.
wouldn't it be better to check result["type"] in the validator? so we can return a proper http 400
There was a problem hiding this comment.
it is checked there -- but the model can do some defaulting on type so I have to check it here as well
technically the database schema is wrong (it should be NOT NULL for that column) but fixing that is a lot more involved
joshuarli
approved these changes
Jun 14, 2024
armenzg
approved these changes
Jun 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.