ref(styles) deprecate space export and add space to theme #75912

JonasBa · 2024-08-09T16:15:36Z

Mods all instances where space() is used inside a styled call. After this, there are ~70 changes where space is called like so that need to be changed.

codecov · 2024-08-09T16:57:24Z

Bundle Report

Changes will increase total bundle size by 10.32kB ⬆️

Bundle name	Size	Change
app-webpack-bundle-array-push	29.52MB	10.32kB ⬆️

codecov · 2024-08-09T17:01:32Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
7656	2	7654	0

View the top 2 failed tests by shortest run time

AlertRuleDetails displays EventUniqueUserFrequencyCondition count�AlertRuleDetails displays EventUniqueUserFrequencyCondition count

Stack Traces | 0.006s run time

Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Number of users affected by an issue is more than 89 in 1d
Received:
  Number of users affected by an issue ismore than 89 in 1d
    at Object.<anonymous> (.../issue/details/textRule.spec.tsx:64:31)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

AlertRuleDetails displays EventFrequencyCondition percentage�AlertRuleDetails displays EventFrequencyCondition percentage

Stack Traces | 0.027s run time

Error: expect(element).toHaveTextContent()

Expected element to have text content:
  Number of events in an issue is more than 1000 in 1h
Received:
  Number of events in an issue ismore than 1000 in 1h
    at Object.<anonymous> (.../issue/details/textRule.spec.tsx:20:31)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

update mod execute changes execute changes remove unused imports ref: remove codemod lint and fix :hammer_and_wrench: apply pre-commit fixes fix

getsantry · 2024-09-05T07:00:06Z

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry · 2024-09-28T07:02:05Z

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry · 2024-10-21T07:00:37Z

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry · 2024-11-12T08:00:15Z

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

JonasBa changed the base branch from master to jb/theme/space August 9, 2024 16:15

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 9, 2024

JonasBa force-pushed the jb/theme/space branch from 6a0bb31 to 1cd5337 Compare August 9, 2024 16:25

JonasBa force-pushed the jb/theme/mod-space-literal branch from f42c86d to 7d79087 Compare August 9, 2024 16:51

vercel bot deployed to Preview August 9, 2024 16:57 View deployment

JonasBa force-pushed the jb/theme/mod-space-literal branch from 3b2b187 to ef20f80 Compare August 9, 2024 17:14

vercel bot deployed to Preview August 9, 2024 17:19 View deployment

ref(space) codemod for tempate literal

6791622

update mod execute changes execute changes remove unused imports ref: remove codemod lint and fix :hammer_and_wrench: apply pre-commit fixes fix

JonasBa force-pushed the jb/theme/mod-space-literal branch from 967d72f to 6791622 Compare August 9, 2024 17:27

Merge branch 'jb/theme/space' into jb/theme/mod-space-literal

fd607a9

vercel bot deployed to Preview August 9, 2024 17:32 View deployment

Merge branch 'jb/theme/space' into jb/theme/mod-space-literal

784e328

vercel bot deployed to Preview August 14, 2024 21:06 View deployment

JonasBa and others added 3 commits August 14, 2024 17:15

Merge branch 'jb/theme/space' into jb/theme/mod-space-literal

3bef946

fixup a few occurences

21798ef

Merge branch 'jb/theme/space' into jb/theme/mod-space-literal

93c253f

vercel bot deployed to Preview August 14, 2024 21:26 View deployment

Merge branch 'jb/theme/space' into jb/theme/mod-space-literal

8b3be23

vercel bot deployed to Preview August 14, 2024 22:56 View deployment

getsantry bot added Stale and removed Stale labels Sep 5, 2024

getsantry bot added Stale and removed Stale labels Sep 28, 2024

getsantry bot added Stale and removed Stale labels Oct 21, 2024

getsantry bot added Stale and removed Stale labels Nov 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ref(styles) deprecate space export and add space to theme #75912

ref(styles) deprecate space export and add space to theme #75912

JonasBa commented Aug 9, 2024 •

edited

Loading

codecov bot commented Aug 9, 2024 •

edited

Loading

codecov bot commented Aug 9, 2024 •

edited

Loading

getsantry bot commented Sep 5, 2024

getsantry bot commented Sep 28, 2024

getsantry bot commented Oct 21, 2024

getsantry bot commented Nov 12, 2024

ref(styles) deprecate space export and add space to theme #75912

Are you sure you want to change the base?

ref(styles) deprecate space export and add space to theme #75912

Conversation

JonasBa commented Aug 9, 2024 • edited Loading

codecov bot commented Aug 9, 2024 • edited Loading

Bundle Report

codecov bot commented Aug 9, 2024 • edited Loading

❌ 2 Tests Failed:

getsantry bot commented Sep 5, 2024

getsantry bot commented Sep 28, 2024

getsantry bot commented Oct 21, 2024

getsantry bot commented Nov 12, 2024

JonasBa commented Aug 9, 2024 •

edited

Loading

codecov bot commented Aug 9, 2024 •

edited

Loading

codecov bot commented Aug 9, 2024 •

edited

Loading