-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ui): Add rspack as webpack alternative #77077
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # build-utils/last-built-plugin.ts # config/rspack.chartcuterie.config.ts # package.json # rspack.config.ts # yarn.lock
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
|
# Conflicts: # package.json # rspack.config.ts # yarn.lock
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## master #77077 +/- ##
===========================================
+ Coverage 57.51% 78.34% +20.82%
===========================================
Files 7179 7191 +12
Lines 317636 318147 +511
Branches 43801 43856 +55
===========================================
+ Hits 182697 249249 +66552
+ Misses 130202 62540 -67662
- Partials 4737 6358 +1621 |
This reverts commit 3c3e8fe.
# Conflicts: # package.json # rspack.config.ts # yarn.lock
# Conflicts: # yarn.lock
Building off the work done in #61475 I think the plan would be to use this as a dev-ui replacement until we're more confident and can setup the getsentry repo as well (if you aren't familiar we have another repo with billing pages etc).
Potential adoption roadmap
Summary
Before
We are using Babel and Webpack for building our frontend application. It took almost 58 seconds on my M2 machine to run
yarn build-production
command.After
Currently it takes 20 seconds to build, minify both JS and CSS files. Uses ~2.9GB memory during dev-ui compared to webpack 3.27GB
RSPACK + SENTRY TODO (updated Oct 7th, 2024)
autoLabel: 'always',
Could just set label setting based on node_env.make build-js-po
Thanks @hardfist for helping with this PR!