fix(releases): increase lock to 10 minutes on set_commits #77660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshFerge
force-pushed
the
jferg/lock-duration
branch
from
2cbce26
to
1bc1d09
Compare
github-actions
bot
added
the
Scope: Backend
roggenkemper
approved these changes
Sep 17, 2024
wedamija
approved these changes
Sep 17, 2024
harshithadurai
pushed a commit
that referenced
this pull request
Sep 19, 2024
we observed SENTRY-3F2A during the rollout of #77453. This didn't make sense until i realized our redis lock is only 10 seconds right now, and this function can take longer than that. We increase the max timeout to 10 minutes, which should be plenty for 99.99+% of `set_commits` calls.
harshithadurai
pushed a commit
that referenced
this pull request
Sep 19, 2024
we observed SENTRY-3F2A during the rollout of #77453. This didn't make sense until i realized our redis lock is only 10 seconds right now, and this function can take longer than that. We increase the max timeout to 10 minutes, which should be plenty for 99.99+% of `set_commits` calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we observed SENTRY-3F2A during the rollout of #77453.
This didn't make sense until i realized our redis lock is only 10 seconds right now, and this function can take longer than that. We increase the max timeout to 10 minutes, which should be plenty for 99.99+% of
set_commitscalls.