Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(custom-views): TabDivider improvements, other style changes #77661

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix(custom-views): TabDivider improvements, other style changes #77661

merged 1 commit into from
Sep 17, 2024

Conversation

MichaelSun48
Copy link
Member

Various cosmetic improvements to custom views:

  1. Tab dividers now disappear when hovering around the add view button
  2. tab dividers disappear correctly when a temp tab is active
  3. The add view button has been given some more left/right padding since it looked very cramped before
  4. The logic to decide whether or not a tab divider should be shown is more readable now.

@MichaelSun48 MichaelSun48 requested review from malwilley and a team September 17, 2024 21:44
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 17, 2024
@MichaelSun48 MichaelSun48 merged commit 5a991fe into master Sep 17, 2024
43 of 44 checks passed
@MichaelSun48 MichaelSun48 deleted the msun/customViews/tabDividerFixes branch September 17, 2024 22:02
harshithadurai pushed a commit that referenced this pull request Sep 19, 2024
@MichaelSun48
fix(custom-views): TabDivider improvements, other style changes (#77661)
19d0027 
Various cosmetic improvements to custom views: 

1. Tab dividers now disappear when hovering around the add view button 
2. tab dividers disappear correctly when a temp tab is active
3. The add view button has been given some more left/right padding since
it looked very cramped before
4. The logic to decide whether or not a tab divider should be shown is
more readable now.
harshithadurai pushed a commit that referenced this pull request Sep 19, 2024
@MichaelSun48
fix(custom-views): TabDivider improvements, other style changes (#77661)
65cf30b 
Various cosmetic improvements to custom views: 

1. Tab dividers now disappear when hovering around the add view button 
2. tab dividers disappear correctly when a temp tab is active
3. The add view button has been given some more left/right padding since
it looked very cramped before
4. The logic to decide whether or not a tab divider should be shown is
more readable now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malwilley malwilley malwilley approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelSun48 @malwilley