Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(dx): Detect bad test runs #77796

Merged
merged 1 commit into from
Sep 19, 2024
Merged

ref(dx): Detect bad test runs #77796

merged 1 commit into from
Sep 19, 2024
+10 −0

Conversation

evanpurkhiser
Copy link
Member

To avoid confusion detect when people try to run jest directly and hint
for them to use yarn test instead of jest directly.

@evanpurkhiser
ref(dx): Detect bad test runs
a2bcf74 
To avoid confusion detect when people try to run jest directly and hint
for them to use `yarn test` instead of jest directly.
@evanpurkhiser evanpurkhiser requested review from a team as code owners September 19, 2024 18:19
@evanpurkhiser evanpurkhiser requested review from scttcper and removed request for a team September 19, 2024 18:19
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 19, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
7889 1 7888 0
View the top 1 failed tests by shortest run time 
Performance > Transaction Tags renders basic UI elements Performance > Transaction Tags renders basic UI elements
Stack Traces | 0.772s run time 
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: {"query": {"project": "1", "statsPeriod": "14d", "tagKey": "hardwareConcurrency", "transaction": "Test Transaction"}}

Number of calls: 0
    at Object.<anonymous> (.../transactionSummary/transactionTags/index.spec.tsx:163:52)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at processTimers (node:internal/timers:511:9)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

scttcper
scttcper approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test flake

@evanpurkhiser evanpurkhiser merged commit fe7a283 into master Sep 19, 2024
46 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-dx-detect-bad-test-runs branch September 19, 2024 23:51
@scttcper scttcper added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Sep 27, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 540274c

getsentry-bot added a commit that referenced this pull request Sep 27, 2024
@getsentry-bot @scttcper
Revert "ref(dx): Detect bad test runs (#77796)"
540274c 
This reverts commit fe7a283.

Co-authored-by: scttcper <[email protected]>
@scttcper
Copy link
Member

scttcper commented Sep 27, 2024 •
edited
Loading

reverting because it breaks the test balancing command yarn -s jest --listTests --json

@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper scttcper approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanpurkhiser @getsentry-bot @scttcper