Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(uptiem): Remove uptime-rule-api flag usage #78151

Merged
merged 1 commit into from
Sep 26, 2024
Merged

ref(uptiem): Remove uptime-rule-api flag usage #78151

merged 1 commit into from
Sep 26, 2024

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner September 25, 2024 21:20
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 25, 2024
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team September 25, 2024 21:21
wedamija
wedamija previously approved these changes Sep 25, 2024
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
21679 1 21678 207
View the top 1 failed tests by shortest run time 
tests.sentry.incidents.endpoints.test_organization_combined_rule_index_endpoint.OrganizationCombinedRuleIndexEndpointTest test_uptime_feature
Stack Traces | 6.46s run time 
#x1B[1m#x1B[.../incidents/endpoints/test_organization_combined_rule_index_endpoint.py#x1B[0m:1050: in test_uptime_feature
    assert [r["id"] for r in json.loads(response.content)] == []
#x1B[1m#x1B[31mE   AssertionError: assert ['25', '24'] == []#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Left contains 2 more items, first extra item: '25'#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Full diff:#x1B[0m
#x1B[1m#x1B[31mE     - []#x1B[0m
#x1B[1m#x1B[31mE     + [#x1B[0m
#x1B[1m#x1B[31mE     +     '25',#x1B[0m
#x1B[1m#x1B[31mE     +     '24',#x1B[0m
#x1B[1m#x1B[31mE     + ]#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-uptiem-remove-uptime-rule-api-flag-usage branch from 2911ed1 to 5d04bd6 Compare September 25, 2024 22:59
@evanpurkhiser
Copy link
Member Author

Changed up the test if you want to take a quick look again @wedamija

@evanpurkhiser evanpurkhiser enabled auto-merge (squash) September 26, 2024 00:07
@evanpurkhiser evanpurkhiser merged commit 1be881c into master Sep 26, 2024
49 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-uptiem-remove-uptime-rule-api-flag-usage branch September 26, 2024 00:07
@wedamija wedamija added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Sep 26, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: bdd1cac

getsentry-bot added a commit that referenced this pull request Sep 26, 2024
@getsentry-bot @wedamija
Revert "ref(uptiem): Remove uptime-rule-api flag usage (#78151)"
bdd1cac 
This reverts commit 1be881c.

Co-authored-by: wedamija <[email protected]>
@getsentry getsentry deleted a comment from wedamija Sep 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wedamija wedamija wedamija approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanpurkhiser @getsentry-bot @wedamija