chore(grouping): Remove all uses of non-optimized-grouping-related code #78260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
lobsterkatie
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #78260 +/- ##
===========================================
+ Coverage 57.37% 78.10% +20.73%
===========================================
Files 7055 7067 +12
Lines 311278 311798 +520
Branches 50894 50964 +70
===========================================
+ Hits 178598 243534 +64936
+ Misses 122532 56503 -66029
- Partials 10148 11761 +1613 |
lobsterkatie
force-pushed
the
kmclb-remove-usage-of-non-optimized-grouping-code-paths
branch
from
17a08ba
to
ebb9708
Compare
lobsterkatie
force-pushed
the
kmclb-remove-usage-of-non-optimized-grouping-code-paths
branch
from
ebb9708
to
ade7255
Compare
JoshFerge
approved these changes
Sep 27, 2024
lobsterkatie
deleted the
kmclb-remove-usage-of-non-optimized-grouping-code-paths
branch
lobsterkatie
added a commit
that referenced
this pull request
Sep 30, 2024
This is a follow up to #78260, which removed all references to code related to the non-unused non-optimized grouping logic, actually removing the code itself. Code which is removed includes: - `_save_aggregate` (the main function controlling the legacy behavior) and its helpers `get_hash_values` and `_get_group_creation_kwargs` - `project_uses_optimized_grouping`, which controls which code path to follow - the `grouping-suppress-unnecessary-secondary-hash` feature flag and the `config_transition.killswitch_enabled` option Once this code is removed there are a few places where we'll be able to clean up what remains, but for ease of review I'm going to do those separately in follow-up PRs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step towards removing the now-unused code paths related to non-optimized grouping, this removes all references to them, both in production code and in tests. Spedifically:
assign_event_to_groupwhich calls_save_aggregate.joband metrics with whether or not optimization is being used.The code itself will be removed in a follow-up PR.