-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(workflow_engine): Phase 1 Remove / Rename WorkflowActions #78272
Conversation
This PR has a migration; here is the generated SQL for --
-- Alter field workflow on workflowaction
--
SET CONSTRAINTS "workflow_engine_work_workflow_id_8ac3c188_fk_workflow_" IMMEDIATE; ALTER TABLE "workflow_engine_workflowaction" DROP CONSTRAINT "workflow_engine_work_workflow_id_8ac3c188_fk_workflow_";
--
-- Custom state/database change combination
--
-- (no-op) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also remove the workflow field from the state in this same pr, using the SeparateDatabaseAndState
step here. This is safe because we remove the constraint when we run migrations, then deploy code.
Then you just need one more pr to actually delete the table
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Description
Pre-req for #78257 to be able to remove the workflow actions table.