feat(explore): Syncing chart cursors. #78285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Zylphrex
reviewed
Oct 1, 2024
Comment on lines
+119
to
+126
| // Synchronize chart cursors | ||
| const [_, setRenderTrigger] = useState(0); | ||
| useEffect(() => { | ||
| if (!timeSeriesResult.isPending) { | ||
| echarts?.connect(EXPLORE_CHART_GROUP); | ||
| setRenderTrigger(prev => (prev + 1) % Number.MAX_SAFE_INTEGER); | ||
| } | ||
| }, [visualizes, timeSeriesResult.isPending]); |
There was a problem hiding this comment.
This seems like a hack to re-run echarts.connect on every render. Can this be limited to just [timeseriesResult.data] so it reconnects each time the timeseries is fetched?
There was a problem hiding this comment.
Hey, tried timeseriesResult.data, the cursors don't persist on hover.
Zylphrex
approved these changes
Oct 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-09-27.at.4.12.22.PM.mov