ref(mediators): Turn project rule creator to dataclass #79137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #79137 +/- ##
==========================================
+ Coverage 78.29% 78.31% +0.01%
==========================================
Files 7133 7134 +1
Lines 314191 314644 +453
Branches 51320 51419 +99
==========================================
+ Hits 246007 246416 +409
- Misses 61748 61767 +19
- Partials 6436 6461 +25 |
markstory
approved these changes
Oct 17, 2024
| r = self.creator.call() | ||
| rule = Rule.objects.get(id=r.id) | ||
| r = self.creator.run() | ||
| rule: Rule = Rule.objects.get(id=r.id) |
There was a problem hiding this comment.
You shouldn't need to provide a type unless there is another variable that is shadowing rule.
markstory
approved these changes
Oct 18, 2024
Christinarlong
deleted the
christinarlong/refactor-mediators-project-rules
branch
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns Creator -> ProjectRuleCreator to dataclass and update uses to be explicit in passing in params