fix(toolbar): Do not import Button into toolbar #80880
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all core components are supported inside the app/components/toolbar/* folder, Button is one of them.
What's going on inside this folder is we've created a new react context, and mounted the toolbar into it. So stuff like
useOrganization
anduseRoutes
doesn't work because we didn't inject the providers. So instead we need to make our own buttons and any other core components that depend on these, also core, providers.By using
<button>
instead of<Button>
the Custom Feature Flag override slide-out is fixed, and so is the "Overrides" list view.These were previously working on dev but not prod. The reason is that there's a
process.env.NODE_ENV
invariant inside the core react context codepath, which runs differently depending on the build :(