chore: remove unused dependencies #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
May 22, 2024
Swatinem
approved these changes
May 22, 2024
| @@ -35,7 +35,6 @@ watto = { workspace = true } | |||
| insta = { workspace = true } | |||
| criterion = { workspace = true } | |||
| symbolic-testutils = { workspace = true } | |||
| similar-asserts = { workspace = true } | |||
There was a problem hiding this comment.
you can probably remove that from the main Cargo.toml now?
There was a problem hiding this comment.
similar-asserts exist in symbolic-cfi
| @@ -28,7 +28,6 @@ insta = { version = "1.28.0", features = ["yaml"] } | |||
| itertools = "0.13.0" | |||
| js-source-scopes = "0.4.0" | |||
| lazy_static = "1.4.0" | |||
| libfuzzer-sys = "0.4" | |||
There was a problem hiding this comment.
interesting, this comes from here:
might be worth running a bit of fuzzing again some day, its been years since the last time I did that :-D
There was a problem hiding this comment.
Yeah, I originally wanted to move those to workspace deps, but it doesn't work because the -fuzz creates live in their own workspaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've given @Boshen 's cargo-shear a try: https://github.com/Boshen/cargo-shear
#skip-changelog