Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around invalid code_file strings in Minidump modules #1115

Closed
loewenheim opened this issue Mar 24, 2023 · 0 comments · Fixed by #1133
Closed

Work around invalid code_file strings in Minidump modules #1115

loewenheim opened this issue Mar 24, 2023 · 0 comments · Fixed by #1133
Labels
enhancement New feature or request

Comments

@loewenheim
Copy link
Contributor

Currently we reject minidumps in which some modules have garbled code_files outright. It would be better to stackwalk the rest of the minidump and just skip the offending modules. To this end, we would need to:

  1. Log an error when we encounter an invalid code_file (this already happens)
  2. Display some placeholder string like <invalid> or <corrupted> in the UI
  3. Replace the useless name with None in derived types that perform lookups based on the code_file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant