Do not fail processing minidumps on invalid code_file
#1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1133 +/- ##
==========================================
- Coverage 73.76% 73.75% -0.02%
==========================================
Files 86 86
Lines 12834 12843 +9
==========================================
+ Hits 9467 9472 +5
- Misses 3367 3371 +4 |
Swatinem
force-pushed
the
mask-invalid-code-file
branch
from
7f701e4
to
abc65b0
Compare
Invalid base-names will be excluded from symbol server lookups, which will certainly not find anything useful. We still output the full (invalid) code file into the symbolicated event, as it might still be useful to customers. As a drive-by change, this reverts the `capture_anyhow` change that captures real stack traces in S4S, as the stack traces are not that useful, and the grouping is worse.
Swatinem
force-pushed
the
mask-invalid-code-file
branch
from
abc65b0
to
5cd3bb6
Compare
Swatinem
changed the title
code_file
loewenheim
requested changes
Apr 7, 2023
crates/symbolicator-service/src/services/symbolication/process_minidump.rs
Outdated
Show resolved
Hide resolved
loewenheim
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid base-names will be excluded from symbol server lookups, which will certainly not find anything useful. We still output the full (invalid) code file into the symbolicated event, as it might still be useful to customers.
As a drive-by change, this reverts the
capture_anyhowchange that captures real stack traces in S4S, as the stack traces are not that useful, and the grouping is worse.fixes #1115, and I verified the minidump linked in getsentry/sentry#46231 processes fine after this change.