ref: Consolidate CacheVersions
#1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves all the places that define `CacheVersions` into a central place, and makes it mandatory to specify explicit versions. It also bumps some cache versions, to start lazy recomputation of some of our caches to the new `CacheKey` format, specifically: Bitcode, Il2cpp, and Objects. CFI, SymCache, Portable PDB, and Meta caches in turn depend on other categories, and will be bumped once the first categories have been migrated.
loewenheim
approved these changes
Feb 15, 2023
Swatinem
force-pushed
the
ref/versions
branch
from
4955758
to
7b30ad7
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
- Coverage 75.12% 75.12% -0.01%
==========================================
Files 84 84
Lines 12006 12004 -2
==========================================
- Hits 9020 9018 -2
Misses 2986 2986 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all the places that define
CacheVersionsinto a central place, and makes it mandatory to specify explicit versions.It also bumps some cache versions, to start lazy recomputation of some of our caches to the new
CacheKeyformat, specifically: Bitcode, Il2cpp, PortablePDB, and Objects.CFI, SymCache and Meta caches in turn depend on other categories, and will be bumped once the first categories have been migrated.