ref: Clean up deprecated Cache features #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that caches have been refreshed using the new stable cache keys, we can remove a couple of legacy code: - Code that deals with legacy cache markers. - Code related to legacy cache paths. - The `should_load` machinery. - SymCache markers, as they are not needed anymore.
Swatinem
force-pushed
the
ref/immutable
branch
from
fc32ee8
to
b0cf656
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1043 +/- ##
==========================================
- Coverage 75.39% 74.96% -0.43%
==========================================
Files 84 83 -1
Lines 12150 11912 -238
==========================================
- Hits 9160 8930 -230
+ Misses 2990 2982 -8 |
loewenheim
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that caches have been refreshed using the new stable cache keys, we can remove a couple of legacy code:
should_loadmachinery.fixes #983, fixes #965
Lets wait with landing this until the lazy cache refresh has progressed a bit more, but it should probably be good to land by tomorrow.