Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symbolicli to connect to reserved IPs #1165

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

tsondergaard
Copy link
Contributor

symbolicli is intended for interactive use and only has the sources configured in .symboliclirc.

@loewenheim
Copy link
Contributor

loewenheim commented Apr 26, 2023

Good catch! Please also add a changelog entry for this.

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #1165 (0f39cb1) into master (af68263) will decrease coverage by 3.09%.
The diff coverage is 0.00%.

❗ Current head 0f39cb1 differs from pull request most recent head 8b58332. Consider uploading reports for the commit 8b58332 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
- Coverage   76.18%   73.10%   -3.09%     
==========================================
  Files          86       86              
  Lines       13220    13221       +1     
==========================================
- Hits        10072     9665     -407     
- Misses       3148     3556     +408     

symbolicli is intended for interactive use and only has the sources configured in .symboliclirc.
@tsondergaard
Copy link
Contributor Author

Good catch! Please also add a changelog entry for this.

Thanks, I've updated the commit and it adds an "Unreleased" section to CHANGELOG.md. @loewenheim, does it look alright to you?

@loewenheim loewenheim enabled auto-merge (squash) April 26, 2023 15:39
@loewenheim loewenheim merged commit a2680ed into getsentry:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants