fix: Refresh symcache when bcsymbolmap status changes #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
reviewed
Jul 14, 2021
Swatinem
commented
Jul 14, 2021
loewenheim
approved these changes
Jul 15, 2021
flub
reviewed
Jul 20, 2021
| SymCache::parse(data) | ||
| .map(|symcache| symcache.is_latest()) | ||
| .map(|symcache| { | ||
| symcache.is_latest() && had_symbolmap == self.bcsymbolmap_handle.is_some() |
There was a problem hiding this comment.
This will also recompute if previously there was a symbolmap but now we didn't fetch one. this can happen because the derived cache lives longer than the download cache. Not sure how serious an issue it is.
| @@ -295,11 +290,26 @@ impl SymCacheActor { | |||
|
|
|||
| match meta { | |||
| Some(handle) => { | |||
| // TODO: while there is some caching *internally* in the bitcode_svc, the *complete* | |||
| // fetch request is not cached | |||
There was a problem hiding this comment.
I wonder if this can be further reduced by checking https://docs.rs/symbolic/8.3.0/symbolic/debuginfo/macho/struct.MachObject.html#method.requires_symbolmap first, obviously only for macho symbol files too. that's probably sufficient rather than introduce an entire new cache which costs a lot of duplicate disk space.
There was a problem hiding this comment.
I don’t think we have a proper MachObject at this point in the code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fetches the symbolmaps before trying to fetch the symcache. The symcache internally persists whether it was using a bcsymbolmap when it was created. That way we can detect if that state changes to refuse to load the cache file and have it regenerate.