WIP: Use tracing::instrument on some processing functions #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can generate traces like this one: https://sentry.io/organizations/sentry-test/performance/rust:daa7a6a37bde40c48165da73693a21a5/?project=1041156
Some problems with this though:
tracing_subscriber::fmt
clashes with env_logger I think. I think rewriting our logging to be completely based on tracing would be a nice idea. But gotta do it in such a way that we don’t break the loggers/configs that do exist.skip
that we don’t want. In our case, we really want none of them, so its kind of a pain in the rear to instrument. There are a couple of issues/feature requests in the tracing repo for this and even a WIP PR to skip all the args, but it takes some time.