Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use tracing::instrument on some processing functions #515

Closed
wants to merge 2 commits into from

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Aug 4, 2021

This can generate traces like this one: https://sentry.io/organizations/sentry-test/performance/rust:daa7a6a37bde40c48165da73693a21a5/?project=1041156

Some problems with this though:

  • the tracing_subscriber::fmt clashes with env_logger I think. I think rewriting our logging to be completely based on tracing would be a nice idea. But gotta do it in such a way that we don’t break the loggers/configs that do exist.
  • we gotta explicitly list all the args as skip that we don’t want. In our case, we really want none of them, so its kind of a pain in the rear to instrument. There are a couple of issues/feature requests in the tracing repo for this and even a WIP PR to skip all the args, but it takes some time.

@flub
Copy link
Contributor

flub commented Aug 4, 2021

I feel like we should have samping figured out before merging something like this. we might just start to hurt s4s really fast and need to be able to undo it quickly

@Swatinem
Copy link
Member Author

Swatinem commented Aug 5, 2021

Well obviously I set that to 100% for testing. Otherwise we can sample way down. Also whats not done yet is to correlate this with a parent trace/span that comes from the workers. That would be interesting as well.

@Swatinem
Copy link
Member Author

actually landed in #628

@Swatinem Swatinem closed this Jan 25, 2022
@Swatinem Swatinem deleted the feat/tracing branch January 25, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants