ref: Make sym/cficache versioning explicit #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
Aug 25, 2021
Swatinem
force-pushed
the
ref/multi-cache-keys
branch
from
4281b0f
to
3bf3ccc
Compare
flub
approved these changes
Aug 25, 2021
This also allows loading outdated sym/cficaches, and provides instructions on how to bump the version, as well as static assertions that enforce version bumps whenever symbolics format version changes.
Swatinem
force-pushed
the
ref/version-caches
branch
from
4def37d
to
b131a12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows loading outdated sym/cficaches, and provides instructions on how to bump the version, as well as static assertions that enforce version bumps whenever symbolics format version changes.
Based on #524 , and should solve https://getsentry.atlassian.net/browse/NATIVE-161 and https://getsentry.atlassian.net/browse/NATIVE-162 though its hard to know :-D
#skip-changelog